Giter VIP home page Giter VIP logo

Comments (2)

tomponline avatar tomponline commented on June 18, 2024

Whilst I agree this is a bug, I am not entirely sure what we should return here for this endpoint.

The problem is that for physical networks, the parent interface can disappear from the host if used by an physical NIC, and so most of the info will not be retrievable, or worse only retrievable when the instance isn't running (and the parent interface has been released back to the host).

But when the physical parent is being used as an OVN uplink it might be quite useful to see the counters of data flowing through it.

@edlerd would it be acceptable to sometimes return 404 on this endpoint if the parent interface is missing, either because its not been configured on the host or if its passed into a running instance?

from lxd.

edlerd avatar edlerd commented on June 18, 2024

@edlerd would it be acceptable to sometimes return 404 on this endpoint if the parent interface is missing, either because its not been configured on the host or if its passed into a running instance?

Yes, we can sometimes have a 404. Can we improve the error message?

Motivation: Reading your explanation, I understand in the OVN case, we want to display the state info for physical managed networks. The UI will show the error message in the other case. But the current error message doesn't make clear, as your explanation above does. I think it is misleading:

image

I think it is the same issue on the command line:

root@latest-edge:~# lxc network info abc
Error: Network interface "abc" not found

where abc exists:

root@latest-edge:~# lxc network show abc
name: abc
description: ""
type: physical
managed: true
status: Created
config:
  parent: eth0
  volatile.last_state.created: "false"
used_by: []
locations:
- none

from lxd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.