Giter VIP home page Giter VIP logo

Comments (6)

canyie avatar canyie commented on July 28, 2024

Does this crash always happen? I guess the break commit is b33057e

from pine.

canyie avatar canyie commented on July 28, 2024

pine/core/src/main/cpp/art/art_method.cpp

Lines 244 to 245 in b33057e

bool clear_jit_info_ref = Android::version >= Android::kN && !Android::MoveJitInfo(source, this)
&& !is_inline_hook && !is_native_or_proxy && art_quick_to_interpreter_bridge;

Previously we won't clear method jit info references on Android S, commit b33057e changed this.

Maybe comment out this line will help?

pine/core/src/main/cpp/art/art_method.cpp

Line 253 in b33057e

entry_point_from_jni_.Set(this, nullptr);

from pine.

canyie avatar canyie commented on July 28, 2024

Oh, the data_ member now refers CodeItem instead of ProfilingInfo in Android 12 so we cannot clear it.
https://cs.android.com/android/platform/superproject/+/master:art/runtime/art_method.h;l=824;bpv=1;bpt=1?q=art_method.h&ss=android%2Fplatform%2Fsuperproject
https://cs.android.com/android/platform/superproject/+/master:art/runtime/art_method-inl.h;drc=master;l=251

However this branch will only be reached if we cannot move jit info, which will be an issue. May you upload full log?

from pine.

avatar commented on July 28, 2024

hi, I'm the user who has been crashing. here is the full log:

adb_logs.txt

from pine.

Vendicated avatar Vendicated commented on July 28, 2024

We can confirm the latest commit fixes it, thanks a lot!

from pine.

canyie avatar canyie commented on July 28, 2024

Checked logs and source code of GrapheneOs, but can't find why MoveObsoleteMethod() does not work. Maybe that ROM does not use JIT compilation so there is no JitCodeCache. Anyway, the problem causing crashes has been fixed, so I think this issue can be closed now.

from pine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.