Giter VIP home page Giter VIP logo

Comments (4)

seveves avatar seveves commented on June 4, 2024

Normally "production" stage is our default channel and there is no need to call setChannel on app startup. But it is possible to switch our app to run against another stage like test or dev and then we need to call setChannel. At the moment we have one init logic and this one is called as soon as the user switches to another stage and therefore we implemented the setChannel inside this logic and that's why we call this on every app startup. Definetely something that we can change in our code but maybe it would be nice to pass the environment/channel in the notifyAppReady call because this one we need to call on every app startup, right?

from capacitor-updater.

riderx avatar riderx commented on June 4, 2024

Thanks @seveves for the comment, notifyAppReady should always be called, but right now this is still called after the native code do the first call to Capgo backend, and this is a limit of Capacitor, i could change the whole logic and wait a signal from the JS to start the Update like manual mode, but i believe allow channel in the config is a better option for automatic mode, what do you think ?

from capacitor-updater.

ap1969 avatar ap1969 commented on June 4, 2024

Hi Martin,
I like this idea. If it's in config, it's easy to work within the build process to change it to a channel appropriate to the dev/prod/whatever app/environment.
Andy

from capacitor-updater.

riderx avatar riderx commented on June 4, 2024

This has been released in https://www.npmjs.com/package/@capgo/capacitor-updater/v/5.5.0
And it's taken to account in Capgo backend here:
https://github.com/Cap-go/capgo/tree/10.454.0
I let you test it, default channel will override any other settings in channel, channel override or device override.

from capacitor-updater.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.