Comments (4)
Normally "production" stage is our default channel and there is no need to call setChannel on app startup. But it is possible to switch our app to run against another stage like test or dev and then we need to call setChannel. At the moment we have one init logic and this one is called as soon as the user switches to another stage and therefore we implemented the setChannel inside this logic and that's why we call this on every app startup. Definetely something that we can change in our code but maybe it would be nice to pass the environment/channel in the notifyAppReady call because this one we need to call on every app startup, right?
from capacitor-updater.
Thanks @seveves for the comment, notifyAppReady should always be called, but right now this is still called after the native code do the first call to Capgo backend, and this is a limit of Capacitor, i could change the whole logic and wait a signal from the JS to start the Update like manual mode, but i believe allow channel in the config is a better option for automatic mode, what do you think ?
from capacitor-updater.
Hi Martin,
I like this idea. If it's in config, it's easy to work within the build process to change it to a channel appropriate to the dev/prod/whatever app/environment.
Andy
from capacitor-updater.
This has been released in https://www.npmjs.com/package/@capgo/capacitor-updater/v/5.5.0
And it's taken to account in Capgo backend here:
https://github.com/Cap-go/capgo/tree/10.454.0
I let you test it, default channel will override any other settings in channel, channel override or device override.
from capacitor-updater.
Related Issues (20)
- feat: Support React native HOT 31
- iOS reviewers wanted for partial update PRs HOT 24
- feat: Check for updates periodically when app is open HOT 6
- bug: failed download because of checksum HOT 4
- feat: disable stats HOT 4
- bug: Fatal error: appId is empty HOT 27
- bug: getLatest returning old data HOT 1
- bug: Crash android 14 HOT 5
- feat: Load other pages as default instead of `index.html`
- feat: allow update endpoint to return custom json data object HOT 2
- bug: After i update using download method ...the version didn't updated...it still remains in previous version HOT 1
- feat: dynamic download URL configuration HOT 3
- feat: ability to update your app on first start HOT 7
- bug: Race condition in backgroundDownload() HOT 1
- bug: iOS Simultaneous accesses to 0x60000023c990, but modification requires exclusive access HOT 7
- bug: Updated bundle scripts does not run (index.js does not exists, there is no such file) HOT 1
- it wont update the app it keep show unknown version
- feat: Capacitor 6 Support HOT 5
- bug: IOS bundle resets after closing app. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from capacitor-updater.