Comments (4)
I'd rather name it placeholder
and it will take a string or a react node.
from react-tweet-embed.
fixed in 84546b3
released as 1.2.1
from react-tweet-embed.
Thanks for implementing that! I can't figure out why it's not working, though:
https://codesandbox.io/embed/billowing-smoke-92zyu
I don't see the placeholder text at all.
from react-tweet-embed.
Actually I do see the text, but very, very briefly, and it takes 3 seconds of white space after the text clears and until the tweets load. Demo.
Wondering if the text could be preserved until the tweets actually show, but that seems to be driven by when the onload callback is called, which is out of the library's control?
Another idea would be to have the children as a placeholder, instead of a prop. That way, the placement and size of the text can be controlled by the developer.
from react-tweet-embed.
Related Issues (20)
- window.twttr.ready is not a function HOT 4
- "ReferenceError: Can't find variable: callbacks" on Safari iOS when bundled w/ webpack HOT 2
- Error with class properties in IE 11 HOT 3
- Invariant Violation: Expected a component class, got [object Object] HOT 3
- not loading inside Cordova HOT 2
- 'window.twittr' is not a sufficient check HOT 3
- Provide a precompiled version or use vanilla JS HOT 1
- add e2e test in pupeteer HOT 2
- Source code for the latest version? HOT 2
- Firefox HOT 1
- show/hide media HOT 2
- React-Native HOT 1
- ID reserved word HOT 1
- disable console log HOT 1
- How to use this library in a React Native project
- placeholder is not exposed as prop HOT 1
- Could not resolve dependency: npm peer react@"^15.0.0 || ^16.0.0" from [email protected] HOT 1
- process is not defined HOT 2
- Can we make isLocal configurable? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-tweet-embed.