Giter VIP home page Giter VIP logo

Comments (4)

capaj avatar capaj commented on July 23, 2024

I'd rather name it placeholder and it will take a string or a react node.

from react-tweet-embed.

capaj avatar capaj commented on July 23, 2024

fixed in 84546b3
released as 1.2.1

from react-tweet-embed.

dandv avatar dandv commented on July 23, 2024

Thanks for implementing that! I can't figure out why it's not working, though:

https://codesandbox.io/embed/billowing-smoke-92zyu

I don't see the placeholder text at all.

from react-tweet-embed.

dandv avatar dandv commented on July 23, 2024

Actually I do see the text, but very, very briefly, and it takes 3 seconds of white space after the text clears and until the tweets load. Demo.

Wondering if the text could be preserved until the tweets actually show, but that seems to be driven by when the onload callback is called, which is out of the library's control?

Another idea would be to have the children as a placeholder, instead of a prop. That way, the placement and size of the text can be controlled by the developer.

from react-tweet-embed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.