Giter VIP home page Giter VIP logo

Comments (11)

peterjmit avatar peterjmit commented on August 17, 2024

There is no good reason for it being commented out, other than omission on my part! I will update this. Thanks for all your feedback 👍

from laravel.

drbild avatar drbild commented on August 17, 2024

Will this be updated?

from laravel.

allaire avatar allaire commented on August 17, 2024

@peterjmit I think the within is not necessary, since it's already in the laravel:artisan command: https://github.com/capistrano/laravel/blob/master/lib/capistrano/tasks/migrations.rake#L3

from laravel.

allaire avatar allaire commented on August 17, 2024

Also, @peterjmit, Any idea why the after hook is not working in this case?

namespace :deploy do
  task :migrate do
    puts "Running migrations..."
    invoke 'laravel:artisan', 'migrate'
  end
  after :updated, 'deploy:set_permissions:chmod'
end

# TODO: Run manually, after hook is not working
# after 'deploy:updated', 'deploy:migrate'

When deploying in verbose mode using the after hook I get:

...
** Invoke deploy:migrate (first_time)
** Execute deploy:migrate
Running migrations...
** Invoke laravel:artisan
...

But when I run the command cap production deploy:migrate -v --trace directly I get:

** Invoke deploy:migrate (first_time)
** Execute deploy:migrate
Running migrations...
** Invoke laravel:artisan (first_time)
** Execute laravel:artisan
INFO[0fdde119] Running /usr/bin/env php artisan migrate --env=production on production.site.com

Any idea why? maybe @leehambley can chime in?

from laravel.

peterjmit avatar peterjmit commented on August 17, 2024

@allaire off the top of my head might well be due to rake only allowing tasks to execute once, this was fixed in http://github.com/capistrano/symfony, I will see if I can fix it here too

from laravel.

allaire avatar allaire commented on August 17, 2024

@peterjmit Where can I read more about this issue?

from laravel.

c0ntax avatar c0ntax commented on August 17, 2024

I've noticed that although the codebase has been updated to comment back in the database migration (8f84614) if you do a gem install of it, you get the commented out version.

from laravel.

javierseixas avatar javierseixas commented on August 17, 2024

Same to me. I guess something should be updated in the gems repository. The version 0.0.2 is too old: https://rubygems.org/gems/capistrano-laravel

from laravel.

ikari7789 avatar ikari7789 commented on August 17, 2024

Sorry for the late response. I'll be helping maintain this plugin for the foreseeable future. If any of these issues are still persisting (all of the tickets are quite old), please let me know and I will do what I can to try and help fix things.

from laravel.

mcblum avatar mcblum commented on August 17, 2024

@ikari7789 I ran into this issue today. I tried running invoke 'laravel:artisan', 'migrate' and I got an error that it had already been invoked. Also when I use the build in migration method it says Application in Production -- command cancelled

from laravel.

ikari7789 avatar ikari7789 commented on August 17, 2024

@mcblum PR #20 should have fixed this. I'll release a minor version update shortly with the fix. Additionally, there is a laravel:migrate_db task which will run migrations.

from laravel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.