CPToolbaritems don't alternate their icon when pressing label about cappuccino HOT 6 CLOSED

CPToolbaritems don’t alternate their icon when pressing label

Invalid.

Take a look at the flickr demo

by Stephan Eggermont

from cappuccino.

CPToolbaritems don’t alternate their icon when pressing label

I’ve looked at the flickr demo, 280slides and at the behavior of the Cocoa toolbar in Pages and other Apple apps.

When you only click on the label of an CPToolbarItem, you don’t see any feedback in the form of the image button going down as if being pressed.

You can even see in the cocotron sources that their implementation of the toolbar behaves exactly the way as in cocoa. (i.e. with the feedback on the image/icon)

So i don’t know why you give me such a short description and redirecting me to the flickr demo. Could you elaborate on this?

(tested under FF and Safari)

by Redmar

from cappuccino.

CPToolbaritems don’t alternate their icon when pressing label

Sorry, clicking on the label doesn’t show the alternate image. It doen’t have anything to do with the target and action though, which should be the same.

by Stephan Eggermont

from cappuccino.

CPToolbaritems don’t alternate their icon when pressing label

It doen’t have anything to do with the target and action though, which should be the same.

It does. Implementation wise. ATM the internals of a toolbaritem are that they contain two duplicate targets and actions but on the outer side, the interface, it only has one target and action.

But by internally using 2 pairs of target/actions you can never capture in the image if the label is pressed because it just fires it’s own target and action.

by Redmar

from cappuccino.

CPToolbaritems don’t alternate their icon when pressing label

Thanks for your bug report.
Do you think you could provide us with sample code that illustrates this bug?
You could upload a sample AppController.j here or more simply paste it on http://gist.github.com and link it here.
It would definitely help to solve it quickly.

by Thomas Balthazar

from cappuccino.

Implemented manual validation for toolbar items and fixed a number of toolbar bugs.

Closed by 8f1e56e.
Closed by 8f1e56e.

Reviewed by me.

from cappuccino.