hard-coded /usr/lib path about capstone HOT 11 CLOSED

yes this is a known problem. can you submit a patch for this?

thanks.

On Sun, Dec 22, 2013 at 10:20 AM, Anton Bolshakov
[email protected]:

Currently, the path is cardcoded in the Makefile.

This might cause a serious mess if /usr/lib isn't a symlink to /usr/lib64
on amd86.

For more details, see the following link:
http://devmanual.gentoo.org/archs/amd64/

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/51
.

from capstone.

Try this hack (at the bottom)
http://stackoverflow.com/questions/9214056/how-can-i-make-a-makefile-determine-the-systems-lib-directory

The configure script might be a long term solution

from capstone.

Anton, on Gentoo 32bit, do you have /usr/lib, or only /usr/lib32??

thanks.

On Sun, Dec 22, 2013 at 11:01 AM, Anton Bolshakov
[email protected]:

Try this hack (at the bottom)

http://stackoverflow.com/questions/9214056/how-can-i-make-a-makefile-determine-the-systems-lib-directory

The configure script might be a long term solution

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/51#issuecomment-31077744
.

from capstone.

It's "/usr/lib" on 32bit, as in the example

from capstone.

this issue has been fixed in the "next" branch, please could you confirm?

you can also see the patch here:

02ac24f

thanks.

On Wed, Dec 25, 2013 at 6:32 PM, Anton Bolshakov
[email protected]:

It's "/usr/lib" as in the example

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/51#issuecomment-31196707
.

from capstone.

Anton, can you confirm this has been fixed in "next" branch?

thanks.

from capstone.

make -j4
Makefile:22: *** missing separator. Stop.

You quoted it with wrong a character, you can't use "if" statement here and the logic might be broken because there is a "/usr/lib" symlink on 64.

Please test your code before committing it. Why don't you not just use the code at the bottom of the link, as I suggested?.. It's easier to understand and it works

# on x86_64, we might have /usr/lib64 directory instead of /usr/lib
LIBDIR.x86_64 = lib64
LIBDIR.i686   = lib
MACHINE := $(shell uname -m)
LIBDIR = $(DESTDIR)$(PREFIX)/$(LIBDIR.$(MACHINE))

from capstone.

no, this will not work since some Linux distros (Ubuntu, for ex) dont have /usr/lib64.

thanks.

from capstone.

sounds like it is a time to create a proper ./configure script if you want to support all platforms easier.

from capstone.

On Wed, Jan 1, 2014 at 9:41 PM, Anton Bolshakov [email protected]:

sounds like it is a time to create a proper ./configure script if you want
to support all platforms easier.

i just committed a fix for "next" branch:

6950f21

can you pull "next" again, and let me know if this fixes the issue on
Gentoo 64bit?

thanks.

from capstone.

yep, fixed. Thank you

from capstone.