Giter VIP home page Giter VIP logo

Comments (12)

captnfab avatar captnfab commented on June 28, 2024 2

I think the bug is fixed in commit bf1f423, I uploaded a new FireTitle version to addons.mozilla.org.
If you have a developer version of Firefox, you can generate the xpi with make and try it.

from firetitle.

grahamperrin avatar grahamperrin commented on June 28, 2024 1

👍 fix confirmed, thanks!

Before a quit

2017-09-13 14 57 37 plasma

Restoring the session

The titles appear, disappear, then reappear at load time.

2017-09-13 15 00 16 plasma 2017-09-13 15 01 09 plasma 2017-09-13 15 01 23 plasma 2017-09-13 15 01 42 plasma 2017-09-13 15 02 14 plasma

from firetitle.

captnfab avatar captnfab commented on June 28, 2024

Crap.
Ok, first, the add-on isn't supposed to be installable on FF 55, the minimum version requirement is 56 since the API used is only present since FF 56.0b7.
However, I'm more sad about the unreliability with Firefox 56.0b10.
Do you have a way to reproduce the problem deterministically? What happen exactly when the title is wrong? Does the window shows the default title? Does it show another tab's title? Does it show only "Mozilla Firefox"?
Thanks for your report.

from firetitle.

grahamperrin avatar grahamperrin commented on June 28, 2024

Hi, this issue is with FireTitle (works with Firefox 3.5 - 56.*), not Crappy Firetitle.

I'll take some shots …

from firetitle.

grahamperrin avatar grahamperrin commented on June 28, 2024

I made a long screen recording of the issue with heavily extended Firefox 55.0.3. A frame from that recording, showing six of twelve windows improperly titled:

2017-09-11 06 08 26 frame

Then, some simple shots of the issue with minimally extended 56.0b10 – FireTitle and Session Manager alone. Work in progress.


For now: I don't know whether these are contributory to the issue, but it's remarkable that not-logged-in (NLI) views of these two URLs (second and third tabs in a single-group four-tab window) present a title only whilst loading – no title when loaded:

from firetitle.

grahamperrin avatar grahamperrin commented on June 28, 2024

A very short recording of an affected window with heavily extended 55.0.3:

https://vimeo.com/233261714

from firetitle.

grahamperrin avatar grahamperrin commented on June 28, 2024

With minimally extended 56.0b10:

2017-09-11 05 48 49

2017-09-11 05 49 17

2017-09-11 05 49 44

from firetitle.

grahamperrin avatar grahamperrin commented on June 28, 2024

OK, I made the bug reproducible. (For weeks, I sensed randomness … this morning I got lucky, pinpointed one affected URL.)

Steps

  1. with 55.0.3 on FreeBSD-CURRENT or 56.0b10 on Kubuntu
  2. create a new profile, named FireTitle
  3. quit
  4. start the FireTitle profile
  5. if more than one tab opens, then manually close all except the first
  6. in the one remaining tab, visit http://www.open-zfs.org/wiki/OpenZFS_Developer_Summit_2017
  7. observe the title bar, OpenZFS Developer Summit 2017 - OpenZFS - Mozilla Firefox
  8. show the menu bar
  9. Tools menu, Add-ons, Extensions
  10. install FireTitle
  11. ignore the prompt to restart
  12. close about:addons, leaving the OpenZFS … tab alone
  13. quit
  14. start the FireTitle profile
  15. History menu, Restore Previous Session

Expected

  • one single-tab window entitled OpenZFS Developer Summit 2017 - OpenZFS - Mozilla Firefox

Actual result

  • in the title bar, either nothing (no text) or Mozilla Firefox

Workaround

  • Command-R reload.

from firetitle.

captnfab avatar captnfab commented on June 28, 2024

Ok, thanks, I've been able to reproduce the bug too. Apparently, some signal of "page loaded" is fired earlier now, so the page title is read before it's loaded...

from firetitle.

grahamperrin avatar grahamperrin commented on June 28, 2024

Great!

Incidentally, I vaguely recall occasional/rare title problems with Firefox 54.x. Maybe the sense of randomness grew during that period. Problems became much more noticeable when 55.0 arrived.

If there's a reasonably easy way to identify the Mozilla changeset(s) underlying this issue, I'll be glad to know.

Many thanks

from firetitle.

captnfab avatar captnfab commented on June 28, 2024

The release notes give some clues: https://www.mozilla.org/en-US/firefox/55.0/releasenotes/

from firetitle.

grahamperrin avatar grahamperrin commented on June 28, 2024

Thanks.

I wondered whether the Firefox 55.0 beginning (or exacerbation) of this issue affecting FireTitle arose from work around Mozilla bug 906076 - (lazytabs) Virtual tabs - lazily create linkedBrowser and other dependent elements for tabbrowser tabs to improve startup performance. Related:

I sped through Mozilla's 906076 and some linked items. A few mentions of titles, but I could not see anything that might have led to this issue 14. I'm not a developer, just curious :-)

from firetitle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.