Comments (9)
I believe we also need to add this to
TextInput
since it could be both invalid and have theSlug
, possiblyTextarea
as well?
hi @tw15egan, that's a good question!
As per the guidelines, we won't be introducing a divider between an interactive and a non-interactive item.
Pasting a screenshot with some Do and Don'ts (for vertical divider in input fields)
( Also, just a headsup, as per my last conversation in Carbon Design crit and with Michael Gower, error states should always be the leftmost. However this is yet to be confirmed by Anna and the C4AI team. I can update latest by Tuesday after the crit regarding the same or sooner if possible. )
from carbon.
@alina-jacob-ibm can you drop an AI design spec into the issue itself. Thx!
from carbon.
carbon-design-system/carbon-design-kit#745 (comment)
from carbon.
I believe we also need to add this to TextInput
since it could be both invalid and have the Slug
, possibly Textarea
as well?
from carbon.
carbon-design-system/carbon-design-kit#745 (comment)
from carbon.
@alina-jacob ah right! Thanks for pointing that out 😄
from carbon.
AI SLUG UPDATE
- There won't be two types of AI Slugs (standard and hollow)
- The hollow slug is now the standard slug with all its associated features.
from carbon.
UPDATE
I did a closer inspection and realised that the spacing that works for the chevron and dismissible icon in the dropdown variants won't work for number input, because in this component the plus and minus items are buttons.
Even though, the icons of these buttons are of 16px, the click area for the button is 48px and that's the same spacing pattern we will have to provide for all subsequent elements coming to the left of the buttons.
Pasting an updated screenshot of the spacing just for the number input component, you can also check out the spacing relation for error and invalid states in the default component here.
from carbon.
All components should have the divider implemented
from carbon.
Related Issues (20)
- [a11y]: Radio Button - Playground - JAWS is not announcing the disabled property
- [a11y]: - Radio Button - Playground - JAWS is not announcing the read only property
- [a11y]: Slider - Playground - Screen Reader is not announcing the "required" attribute of Slider Control
- datatable component high memory usage issue
- [a11y]: Slider - Playground - Screen Reader is not announcing the Read-only status for the Slider control
- [a11y]: Select - Default - JAWS is announcing multiple times for the name of the input label
- [a11y]: Select - Playground - Read-only status is not applied
- [a11y]: Select - Playground - JAWS is announcing the name of the label even after hiding the label from playground
- [a11y]: Select - Playground - JAWS is not announcing the warn state of the combo box
- [Bug]: Multiselect - Selected value not updated as per latest passed value
- [AI] Rename the `slug` component to `AI label`
- [AI] Bring `slug` component to stable
- [Bug]: (Tabs) React 19 not rendering TabList items HOT 2
- Number input - Storybook crashed when setting max value HOT 2
- [Bug]: Error button inside <ComposedModal> has flickering issue while hovering
- [Bug]: ComboBox - allowCustomValue no longer fires change event with custom value HOT 1
- [Bug]: Pagination - incorrect display when there are no items
- [Bug]: Tab with long label text is not rendering properly in smaller screens
- [Bug]: DataTableSkeleton renders tooltip content in the Header
- [Bug]: ComboBox: Using the `shouldFilterItem` prop no longer works with onChange
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from carbon.