Comments (9)
But isn't consistent with the jQuery style of overloading methods.
It also seems to be inconsistent in itself with how a cookie is written. If at all there should then be a addCookie
function along with removeCookie
.
from jquery-cookie.
I may disagree with you. See the following example:
$().attr("id", "myID")
$().removeAttr("id")
There is no $().addAttr
removeCookie is much more intuitive and follow jquery's style
from jquery-cookie.
@carhartl Did you thought about this? Seriously I think it is a very good feature and it does'nt add so many chars =(
from jquery-cookie.
Nearly convinced.
from jquery-cookie.
$.removeCookie = function(name, options) {
$.cookie(name, null, options);
};
from jquery-cookie.
Do u think the options are needed here?
My idea here is simulate the "options.expires = -1" by aliasing
You may probably be able to do this without testing all the stuff $.cookie does, but I don't think the performance improvement would be noticeable
from jquery-cookie.
I think yes, it's required. You can only remove the cookie with the same options (path and domain options are the important ones here) that were used to write it in the first place. Basically removing the cookie is nothing else than a write.
You could have written a cookie for different paths:
$.cookie('foo', 'bar', { path: '/one' });
$.removeCookie('foo', { path: '/one' });
$.cookie('foo', 'bar', { path: '/two' });
$.removeCookie('foo', { path: '/two' });
Of course passing options isn't necessary when relying on the default options.
from jquery-cookie.
Don't think performance is a real issue here, unless you're deleting 1000 cookies in a row maybe.
from jquery-cookie.
Let's consider #87 on this one
from jquery-cookie.
Related Issues (20)
- If the cookie time is up, then the cookie value is what? undefind or null? HOT 1
- Line Break HOT 1
- Line Break HOT 9
- Request - version bump on js files or revert master HOT 12
- [NuGet] Align naming convention between minified and base .js files in package HOT 2
- $.removeCookie is not deleting cookie in Chrome HOT 13
- A Session Cookie not working HOT 8
- Cookies deleted when page open without query parameters HOT 2
- $.removeCookie is not a recognized on Chrome HOT 7
- Cookie gets restored magically after some time HOT 7
- Disable issues? HOT 2
- Escape # char
- Cookie not set in IE10 HOT 1
- Do not create an issue here! HOT 3
- Bower crashing if using jquery-cookie 1.4.1 HOT 2
- Unable to install using Bower HOT 6
- Fail update cookie? HOT 2
- jquery cookie support for http flag true HOT 2
- Cookie Https HOT 2
- suggestion: add function for parse signedcookies in next rev HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jquery-cookie.