Giter VIP home page Giter VIP logo

Comments (9)

CarlosOrozco88 avatar CarlosOrozco88 commented on July 3, 2024 1

The main problem is detecting ui5 projects. I mean, in case of not using multiroot workspaces, it is necessary to search for every manifest and parse it (im checking it has sap.app.id property). In order to do the same logic in every workspaces, i do this search allways.

The extension has a function that do this search at startup. But you can add, remove or update manifests files so the extension has to listen for changes in manifests files in order to execute the search function again (other files like .env file - to restart the server - and each project file - to restart browser -).

Thats why i am using chokidar. In 0.6.X chokidar was used only for browser refresh, and manifest files are watched with vscode api. The main problem is that it cant detect file changes outside the ide, like copy paste files or similar and i cannot trust the projects are allways detected correctly, so in every server start i was doing a project search that it is not needed now.

Conclusion: i will check for a real solution with chokidar. If there are not one, i will look for another dependency or change the extension do manifest discovery.

Hope this explains the problem

Thanks!

from ui5-tools.

jayakrishnanc2013 avatar jayakrishnanc2013 commented on July 3, 2024 1

Thanks Carlos for the explanation 👍🏼

from ui5-tools.

CarlosOrozco88 avatar CarlosOrozco88 commented on July 3, 2024

Hi!

Are you using a windows system? I am using a mac and i do not have this issue.

I will check it later.

Thanks for the report

from ui5-tools.

jayakrishnanc2013 avatar jayakrishnanc2013 commented on July 3, 2024

Hi Carlos, yes i am using windows

from ui5-tools.

CarlosOrozco88 avatar CarlosOrozco88 commented on July 3, 2024

Can you build the project? I mean, the problem is in both options (deploy/build) or only in deploy?
image

from ui5-tools.

jayakrishnanc2013 avatar jayakrishnanc2013 commented on July 3, 2024

Yes in both cases.

from ui5-tools.

jayakrishnanc2013 avatar jayakrishnanc2013 commented on July 3, 2024

from ui5-tools.

CarlosOrozco88 avatar CarlosOrozco88 commented on July 3, 2024

Hi,

it seems it is a chokidar/windows issue. I just published ui5-tools 1.0.3 with a few changes to workaround the problems in dist folder.

Wish it works

Thanks!

from ui5-tools.

jayakrishnanc2013 avatar jayakrishnanc2013 commented on July 3, 2024

Hi Carlos, Yes now i am able to build and deploy it to the SAP System. As you mentioned it is a workaround , will it be a complete solution or how? Could you please give some info on this.
Thnaks,
JK.

from ui5-tools.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.