Comments (14)
Hi, @orchid00. I can't find challenges in the repository with lesson on SQL. Can you point me at them?
from styles.
from styles.
@gvwilson do you both mean "FIXME"s?
from styles.
I meant the font of the titles called "challenges" so all of them. It is a matter of style: they are very spacious in between, and probably the question title (where it says fixme) should be a bit smaller. Is that clearer?
from styles.
Thanks @orchid00 and @gvwilson. My fork, for reason unknown to me, contained "FIXME" headers instead of proper challenges as, for example, here http://swcarpentry.github.io/sql-novice-survey/01-select.html (at the bottom).
I've pulled in the recent changes and will work on styles some more.
from styles.
Hi everyone,
I don't like that light-green color of challenge boxes. I'd get rid of it, and to highlight that this section is a challenge I'd put it under "Challenge" (or "Exercise") header.
Pros:
- clear indicator that this section is intended as an exercise for reader
- proper heading structure (each challenge is a subsection of "Challenges")
- visually more appealing
Cons:
- requires changes to lesson files
What do you think?
from styles.
Good idea to remove the green boxes!
Btw, I am looking at version 5.3, and the headers of the tables are different than yours. have a look:
Can you modify that too?
from styles.
@orchid00 I accidentially showed you a lesson with #10 applied - it changes tables a bit, now they're similar to what Bootstrap offers.
What do you think about that additional header "Challenges"? Should I keep it or throw away?
from styles.
Oh! tables look much better like that.
To be honest, I'm very picky and and I don't think much ppl will notice those things, but here you go:
now that you removed the green highlight the left padding looks a bit off. If you put everything aligned to the Challenges (header) it would look better, in that case keep it.
Also, we talked with some other instructors that the challenges should come more often and not only at the end of the lesson. But I guess that is a more structural change. In that case wouldn't be necessary to write challenge headers :P
from styles.
To be honest, I'm very picky and and I don't think much ppl will notice those things, but here you go:
now that you removed the green highlight the left padding looks a bit off. If you put everything aligned to the Challenges (header) it would look better, in that case keep it.
Also, we talked with some other instructors that the challenges should come more often and not only at the end of the lesson.
Oh I really like this change.
But I guess that is a more structural change. In that case wouldn't be necessary to write challenge headers :P
You're right. This gives me an idea of how to bring nice-looking exercises inside the lesson's content.
Take a look at this "Note" section here: it looks like a box with a header, but it's not disturbing.
I'm thinking a similar style for challenges: it has to be a box, because challenges sometimes get more than one paragraph of text, and it must not be disturbing, ie. header should be fairly small and colors not too bright.
I'll probably throw away my previous changes to challenges and prepare something that presents these exercises nicely and inline, not at the end of the lesson.
from styles.
Yeah the box with the header looks OK. I think before it was just the color green that didn't look so nice.
Again, I see something different, your queries are now in grey-ish? and my queries are color green...
from styles.
Again, I see something different, your queries are now in grey-ish? and my queries are color green...
The queries in grey-ish had no class="sql"
({.sql}
in Markdown) - good catch. This is an issue for sql-novice-survey, you can send a PR if you want.
from styles.
@pbanaszkiewicz (I'm new here) where should I do the PR?
from styles.
@orchid00 that's alright. I think the issue is that code blocks in challenges miss {.sql}
. I've found a couple of lessons that do not have it:
- http://swcarpentry.github.io/sql-novice-survey/01-select.html
- http://swcarpentry.github.io/sql-novice-survey/03-filter.html
- http://swcarpentry.github.io/sql-novice-survey/05-null.html
Here's an issue ticket I've just created: swcarpentry/sql-novice-survey#34
Please send a PR to the https://github.com/swcarpentry/sql-novice-survey/ repository.
from styles.
Related Issues (20)
- Allow blank lines and comments when checking `links.md` HOT 3
- Allow for non-spaced links in internally-defined Markdown-links
- Allow for non-numbered episodes in checks
- Allow skipping line length checks for link-only lines HOT 5
- Optional dropdown section HOT 2
- Syncing lessons with styles repository HOT 2
- Update cache mechanism for R packages
- Broken link in Boilerplate Contributing.md HOT 3
- Improve `make lesson-check` output HOT 3
- Publishing HTML files for Workshop Extras HOT 1
- Code Checking Utility HOT 1
- remove travis files
- Low color contrast HOT 1
- Encoding error when trying to serve a jekyll project HOT 10
- Use rem units for font-size, normalise font sizes between headers and body text HOT 3
- "title" attribute for code blocks HOT 2
- Page titles are taken from the first heading if no title exists HOT 9
- set-output workflow command deprecated HOT 2
- [workflows] Unable to resolve action r-lib/actions@master HOT 4
- [workflows] set-output deprecated
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from styles.