Comments (7)
JacobHayes
commented on May 18, 2024
1
Hi @jatorre have you had a chance to take a look at this? If not, could you point me to what I'd need to do? I'd be happy to PR it. It's obviously due to this line referencing an undefined window in the false case of the condition, but not sure exactly what it should reference instead.
from analytics-toolbox-core.
XavierLavenir
commented on May 18, 2024
1
Are there any plans to implement this soon? Would be really useful
from analytics-toolbox-core.
jatorre
commented on May 18, 2024
Yep, sorry did not have time to bundle correctly the S2 library, is there, but not bundled
from analytics-toolbox-core.
mentin
commented on May 18, 2024
Permissions seems to be OK now, but I'm now getting
SELECT jslibs.s2.latLngToKey(1,2,3)
ReferenceError: window is not defined at gs://bigquery-jslibs/s2geometry.js line 594, columns 52-53
from analytics-toolbox-core.
jatorre
commented on May 18, 2024
Yeah. Still need to be processed to remove the window part. Will get into
it ASAP
On Tue, 5 Nov 2019 at 22:45, Michael Entin ***@***.***> wrote:
Permissions seems to be OK now, but I'm now getting
SELECT jslibs.s2.latLngToKey(1,2,3)
ReferenceError: window is not defined at
gs://bigquery-jslibs/s2geometry.js line 594, columns 52-53
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA7GO3OIBVM7ACPWDH53PLQSHSQHANCNFSM4IQHCB2A>
.
--
*Javier de la Torre*
Chief Strategy Officer | [email protected]
<https://www.carto.com/>
from analytics-toolbox-core.
jatorre
commented on May 18, 2024
No, haven’t looked at it. The work to be done is to bundle the s2 js
library in a window less, like if it was a nodejs library and then add the
methods.
I think I used browserify with other libraries but I am not an expert on
packaging JS libraries and always have to try multiple things.
On Fri, 31 Jan 2020 at 00:30, Jacob Hayes ***@***.***> wrote:
Hi @jatorre <https://github.com/jatorre> have you had a chance to take a
look at this? If not, could you point me to what I'd need to do? I'd be
happy to PR it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA7GOZ4XBWUQ2SU3HHTAIDRANPJZANCNFSM4IQHCB2A>
.
--
*Javier de la Torre*
Chief Strategy Officer
+34 911 165 823 | [email protected]
[image: Spatial Data Science Ebook]
<https://go.carto.com/ebooks/spatial-data-science>
from analytics-toolbox-core.
jatorre
commented on May 18, 2024
It should be possible now thanks to @francois-baptiste and there are a few other options
from analytics-toolbox-core.
Related Issues (20)
- option for makevalid => TRUE when converting geojson back to geography in BQ HOT 3
- S2 Contains/prefix match (bigquery) HOT 1
- Snowflake Performance HOT 3
- How to build the project HOT 2
- Quadkey sibling shouldn't wrap at the pole HOT 1
- QUADINT_TOZXY and QUADINT_FROMZXY do not detect invalid QUADINT nor ZXY HOT 1
- Error when executing H3_CENTER HOT 5
- Upgrade to h3 v4.0.0 HOT 1
- Redshift S2_BOUNDARY returning incorrect boundary HOT 2
- H3 directed edge support HOT 1
- Core functions no longer available on Snowflake HOT 8
- Sporadic failure of Snowflake user defined functions in the carto h3 module HOT 5
- S2 'level' 0 should be allowed
- carto.H3_BOUNDARY returns null for some valid cell IDs HOT 2
- Add support for H3_CENTER / H3_CELL_TO_LAT_LNG on Snowflake HOT 3
- carto.PLACEKEY_TOH3 occasionally produces invalid H3s on Snowflake
- No active warehouse selected in the current session. Select an active warehouse with the 'use warehouse' command. HOT 3
- adding support for middle east HOT 3
- Snowflake ST_DELAUNAYPOLYGONS error with aggregation HOT 5
- ST_DESTINATION Documentation HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from analytics-toolbox-core.