Giter VIP home page Giter VIP logo

Comments (7)

cartoonist avatar cartoonist commented on May 30, 2024

Sorry, I did not get what you mean by being folded. You mean wrapped?

from kseqpp.

cartoonist avatar cartoonist commented on May 30, 2024

I added an option to disable line wrapping by calling set_nowrapping method before writing any record. Since this is a re-implementation of "kseq" library, I did not change the default behaviour. Please check the develop branch. If it also works for you, I will merge it to master.

from kseqpp.

omegahh avatar omegahh commented on May 30, 2024

Yes, I mean 'wrapped'. For most FASTQ files, The seq line and qual line are not wrapped. As far as I know, the wrapped FASTQ is not accepted by many downstream softwares, for example: bowtie2.
So my suggestion is, in default manner, the FASTA file should be wrapped while the FASTQ file should not be wrapped.

from kseqpp.

cartoonist avatar cartoonist commented on May 30, 2024

That makes sense. I am going to do the following then:

  • add a parameter to SeqStreamOut class to specify the underlying file format (accepting format::fasta, or format::fastq values in klibpp namespace). Actually KStreamOut class which is the base class of SeqStreamOut has already this option which just needs to be forwarded.
  • if the format is explicitly set to format::fastq, no-wrapping would be the default behaviour, otherwise it wraps at 60bps.
  • just for the record, puts no longer gets wrap parameter and wrapping is determined by the wraplen value. If it is zero, it means no wrap.

from kseqpp.

cartoonist avatar cartoonist commented on May 30, 2024

Please check out develop branch (sorry for the forced push!), let me know if it works.

from kseqpp.

omegahh avatar omegahh commented on May 30, 2024

Sorry for delayed reply. I am on the vocation due to Chinese national day.

from kseqpp.

cartoonist avatar cartoonist commented on May 30, 2024

No problem, feel free to reopen the issue if the problem persists.

from kseqpp.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.