Giter VIP home page Giter VIP logo

Comments (4)

JakeWharton avatar JakeWharton commented on July 26, 2024

Filed https://issuetracker.google.com/issues/306428078 upstream since there seems to be some support for this being a first-party toggle of the Compose compiler itself.

from redwood.

JakeWharton avatar JakeWharton commented on July 26, 2024

Realizing that even with toggles this won't fully eliminate these calls since we don't control the flag value in libraries (such as the Compose runtime itself, where they're enabled). So still need to build a solution that also applies somehow to libraries, not just the code in the compilation unit.

from redwood.

JakeWharton avatar JakeWharton commented on July 26, 2024

We can do this during linking with a regular compiler plugin because linking sees all the IR, not just the compilation unit of the current module.

https://kotlinlang.slack.com/archives/C7L3JB43G/p1698130170671859?thread_ts=1698116255.957259&cid=C7L3JB43G

from redwood.

colinrtwhite avatar colinrtwhite commented on July 26, 2024

Might be worth stripping all calls functions in Preconditions.kt since the nullability for our code is already enforced at compile time and those functions are called very frequently. This is already possible via compiler flag for the JVM and will eventually be supported for JS.

from redwood.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.