Selected text better color distinction about jetbrains HOT 10 CLOSED

Hello! Finally getting around to revisiting this.

As per recommendations suggested on discord, I've updated the comments to be overlay2 and increased the contrast on the selection highlight.

What do people think about this for the next release? (Excluded Frappe, Macchiato since they're basically the same as Mocha in the screenshots below)

@kkrypt0nn @BButner @pohy

Mocha

Latte

from jetbrains.

Thanks for raising this.

While I agree that VSCode has better highlights for this. There's a small tradeoff being made here:

1. VS selection highlights only actually select the text and don't highlight the cursor line behind it, making it easier to select a lighter colour
2. I don't believe comments are well highlighted/readable with the lighter colour.

Having messed with the colours, I've found that it's really hard to make the selection background highlight look good for normal code and comments :/

I'd be super happy if someone could mess around with it enough to make it look good for both

from jetbrains.

I have also discovered an additional issue inside dialogs. ToggleSite.tsx in the To input field is highlighted/selected. Honestly, I cannot distinguish the selection from the background even upon close inspection.

(macOS WebStorm 2022.3.1, Catpuccin 2.0.7 Macchiato variant)

Hmmm, this is quite weird. I don't think there are any different highlights for these dialogs but I could be wrong. I'll try to look into it when I have time! Running pretty low on that right now 😅

from jetbrains.

Looking amazing to me :D

from jetbrains.

Great! I'll close this as the new changes are implemented with the release of 2.1.0
I'd imagine it'll be reviewed and released to the marketplace from W.B Monday 3rd April!

from jetbrains.

@sgoudham To me it looked already nice before, following the suggestion of changing the color used makes it stand out even better, looking awesome to me ✨

from jetbrains.

Thanks for raising this.

While I agree that VSCode has better highlights for this. There's a small tradeoff being made here:

1. VS selection highlights only actually select the text and don't highlight the cursor line behind it, making it easier to select a lighter colour
2. I don't believe comments are well highlighted/readable with the lighter colour.

Having messed with the colours, I've found that it's really hard to make the selection background highlight look good for normal code and comments :/

I'd be super happy if someone could mess around with it enough to make it look good for both

Too be fair, using the VSCode theme as a reference... The highlighting there has the same issue with the comments, they almost disappear:

I think the tradeoff would be worth it. Personally, I'd rather have a higher contrast highlight color and not be able to read comments while I'm doing so.

If you're fine with this tradeoff/if enough people thumbs up here, I'm happy to PR this to match the color that VSCode uses.

from jetbrains.

I have also discovered an additional issue inside dialogs.
ToggleSite.tsx in the To input field is highlighted/selected. Honestly, I cannot distinguish the selection from the background even upon close inspection.

(macOS WebStorm 2022.3.1, Catpuccin 2.0.7 Macchiato variant)

from jetbrains.

Thanks for raising this.
While I agree that VSCode has better highlights for this. There's a small tradeoff being made here:

1. VS selection highlights only actually select the text and don't highlight the cursor line behind it, making it easier to select a lighter colour
2. I don't believe comments are well highlighted/readable with the lighter colour.

Having messed with the colours, I've found that it's really hard to make the selection background highlight look good for normal code and comments :/
I'd be super happy if someone could mess around with it enough to make it look good for both

Too be fair, using the VSCode theme as a reference... The highlighting there has the same issue with the comments, they almost disappear:

I think the tradeoff would be worth it. Personally, I'd rather have a higher contrast highlight color and not be able to read comments while I'm doing so.

If you're fine with this tradeoff/if enough people thumbs up here, I'm happy to PR this to match the color that VSCode uses.

Funnily enough, the highlights were the same as VSCode in the earlier releases and then an issue (#24) was raised about comments not being visible ahaha!

from jetbrains.

Re-opening this as I incorrectly read the suggestion to be overlay2 instead of overlay0. Our NeoVim & VsCode ports use that at the minute so I would like to match them and keep the legibility on the selection highlight.

It was pointed out to me that using overlay2 does not make the comments stand out on their own enough, which I do agree with looking back at it.

How do people feel about the following screenshots? We are using overlay0 for comments now and I've tried to tweak the selection highlights. @kkrypt0nn @BButner

Mocha

Latte

I like it as it's a middle ground between the old comments and the new ones proposed above. If it's fine, I'll make a 2.1.1 release "fixing" this.

from jetbrains.