Comments (1)
You will find that the outer Or
is evaluating to True and short circuiting (not evaluating the second argument) because And(IsReadOnlyRequest, IsAuthenticated).has_object_permission
returns True
.
This is because IsReadOnlyRequest
and IsAuthenticated
both inherit from BasePermission
which just returns True
for has_object_permission
. This is a gotcha when combining permissions with an or
, which doesn't normally happen with the default DRF behavior.
To get your desired behavior, you will need to subclass IsReadOnlyRequest
and IsAuthenticated
so that their has_object_permission
returns a meaningful result. I normally just do this:
class IsAuthenticated(permissions.IsAuthenticated):
def has_object_permission(self, request, view, obj):
return self.has_permission(request, view)
from rest_condition.
Related Issues (8)
- has_object_permission does not get called after first permission in Or HOT 12
- Combining has_permission with has_object_permission isn't working
- Custom Error Messages Not Working HOT 1
- Or conditionals shortcutting prematurely HOT 6
- Permissions not treated as units HOT 1
- Permission check return values should be explicitly casted to bool HOT 1
- using rest framework's IsAuthenticated break the condition evaluation in django 1.10 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rest_condition.