Comments (2)
emekoi
commented on August 10, 2024
this doesn't seem like a difficult fix so i will try to submit a PR, but where did you get the bounds for this function? they don't seem to align with the SVGs, kanjivg has.
from kanji-colorize.
cayennes
commented on August 10, 2024
Those numbers come from the unicode values of the kanji range to differentiate kanji from other characters. You're right this is an easy fix; it just needs the conditional to check whether the string has kanji rather than whether it is a single character.
I've updated the description to specify what the actual desired behavior is.
from kanji-colorize.
Related Issues (20)
- test fails with missing 0041b.svg
- clean up test setup
- general code cleanup
- investigate bug with generate all new HOT 5
- get the standard library dependencies that aren't included in anki out of the addon
- reorganize for easier development and building
- Hi there, HOT 1
- Note: If you don't have a github account you can also email me at [email protected] HOT 1
- Error with Anki 2.1.28 HOT 2
- configuration option for what characters to diagram in anki
- TypeError when generating new notes
- Option to prevent changing field if something is in it. HOT 2
- Create add-on file for manual installation HOT 3
- Direct SVG inside the Diagram Field HOT 3
- Diagram for 備
- FYI: Generated for two katakana words and got "divdivdiv(correctkatakana)divdiv"
- Stroke Order not working HOT 2
- Request: Bulk-add only to selected cards from browser or manually colorize from card editor (not on tab)
- Request: Update colorized-kanji-contrast.tgz & colorized-kanji-spectrum.tgz based on newest kanjivg data
- Readme Typo HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kanji-colorize.