Giter VIP home page Giter VIP logo

Comments (7)

cayennes avatar cayennes commented on August 10, 2024

Thanks for the report.

Can you create a one-card deck that reproduces the issue and attach it here?

from kanji-colorize.

cayennes avatar cayennes commented on August 10, 2024

(Also I don't make any promises about when I will find time to work on this)

from kanji-colorize.

alexpizarroj avatar alexpizarroj commented on August 10, 2024

I've finished working on a fix for this.

This is an excerpt of a comment on the AnkiWeb add-on page. It explains how to reproduce the issue:

The bug [...] that causes error messages and "Waiting for editing to finish/Resume Now" over and over, is still there. [...] The way to cause this error is to start studying your card deck, and get to a card containing a colorized kanji, then clicking Edit and then Done and it will happen.

What I found out was that there's something weird going on when you hit the Close button while using the Edit Note dialog (it won't happen if you just close the window hitting the ESC key). The addKanji function will be called indefinitely unless we signal that we have not made any changes to the current note through the return value of addKanji (i.e. return flag).

Since I've also heard other people complain about the add-on re-writing the Diagram field whenever you mistakenly cycle through the Kanji field, I feel that just avoiding filling a non-empty Diagram field should be the way to go.

Let me know what you think. If there's something else to be done, I'd gladly help.

from kanji-colorize.

Quinnlet avatar Quinnlet commented on August 10, 2024

Hey Cayennes! Thanks for the speedy reply, and I made a one card deck like you suggested. I am not sure how to change the format of files and it wouldn't let me drag and drop the Anki deck directly into this text box so I put it on Google Drive. If not might need some guidance on how to attach on this site.

But the bug is just how Alex suggests - I open the card I want, click space to see both front and back then go to editing, once coming out of editing that's when the bug happens.

And thanks! I didn't know that pressing the esc key would work, but it seems to. :))

from kanji-colorize.

cayennes avatar cayennes commented on August 10, 2024

from kanji-colorize.

Quinnlet avatar Quinnlet commented on August 10, 2024

Looking forward to the new release! I'll keep an eye out on Anki addon site. Thanks so much for resolving it quickly, and also have a merry xmas. :P

from kanji-colorize.

cayennes avatar cayennes commented on August 10, 2024

I've fixed it and uploaded the new version.

from kanji-colorize.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.