Giter VIP home page Giter VIP logo

Comments (1)

dennwc avatar dennwc commented on June 6, 2024

Hmm, this one is tricky, since we never defined what will happen with empty values.

Definitely, the returns don't make any sense from user's point of view. I think LabelContext is trying to be nil-safe and ignores the empty argument in the last two cases.

I think we should enforce the following behavior:

  • LabelContext("") - list none (it searches for a typed empty string)
  • LabelContext(quad.IRI("")) - list none (it searches for an empty IRI)
  • LabelContext(quad.Raw("")) - list node2 (same as nil)
  • LabelContext(nil) - list node2 (what you would expect)

The problem is that we need to check the code to make sure it doesn't expect something like this to work:

var label quad.Value
if something {
   label = quad.IRI("x")
}
// expects that if label is nil, the filter will be skipped
p = p.LabelContext(label)

from cayley.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.