Signature FAILED - CSR has an invalid signature problem using this library about certificatesigningrequest HOT 4 CLOSED

Hi @iosdevninja,

I checked one of my generated certificates and I don't run into this issue. I have attached a screenshot for reference.

My thinking is this is not an issue with this framework but an issue with your code. My reasoning for this is I quickly looked through your code (I don't have much time this week) and see a problem which could be causing your issue. Line 101 of your code you have:

let csrString = csrBuild.base64EncodedString(options: Data.Base64EncodingOptions(rawValue: 0))

This will not work. In iOSCSRSwiftTests.swift, I state this should be:

let csrString = csrBuild.base64EncodedString(options: Data.Base64EncodingOptions(rawValue: 0)).addingPercentEncoding(withAllowedCharacters: CharacterSet.alphanumerics)

The line below should work as well (depending on your swift version):

let csrString = csrBuild.base64EncodedString(options: Data.Base64EncodingOptions(rawValue: 0)).stringByAddingPercentEncodingForFormUrlencoded()!

Encoding incorrectly will definitely cause your CSR to fail.

CSR Decoder and Certificate Decoder.pdf

If there is still an issue, I won't be able to look at it until next week.

Let me know if this solves your problem.

from certificatesigningrequest.

Hello Corey,

Thank you very much for your prompt reply.

I did the code change as you suggested (Swift 3 one)

let csrString = csrBuild.base64EncodedString(options: Data.Base64EncodingOptions(rawValue: 0)).addingPercentEncoding(withAllowedCharacters: CharacterSet.alphanumerics)

and then print out the new generated CSR string.

I am enclosing it as an attachment on this thread.

The problem is it is still NOT working when tested in https://redkestrel.co.uk/products/decoder/

If you check on the new generated CSR now it comes with % values all across the text.

Please provide advice when you have a free moment.

Kind regards

CSR_After_Code_Change.zip

from certificatesigningrequest.

@iosdevninja it appears the encoding line I gave you earlier was still correct. Correcting two lines of your code will fix your problem:

let csrString = csrBuild.base64EncodedString(options: Data.Base64EncodingOptions(rawValue: 0)).addingPercentEncoding(withAllowedCharacters: CharacterSet.urlQueryAllowed)

let formattedCSRString = String(format:"%@%@%@","-----BEGIN CERTIFICATE REQUEST-----\n", csrString!, "\n-----END CERTIFICATE REQUEST-----\n")

I have attached the CSR created using your code. My apologies for the late reply.

If there is still an issue, this string extension seems to encode perfectly:

CSR Decoder and Certificate Decoder.pdf

from certificatesigningrequest.

@iosdevninja I added two methods which encodes the CSR for you:

Full CSR string:
let builtCSR = csr.buildCSRAndReturnString(publicKeyBits, privateKey: privateKey)

CSR without header and footer:
let builtCSR = csr.buildAndEncodeDataAsString(publicKeyBits, privateKey: privateKey)

from certificatesigningrequest.