Giter VIP home page Giter VIP logo

Comments (4)

glyn avatar glyn commented on June 1, 2024 1

I agree we should focus on the consensus test suite.

Related: What's going to be the arbiter on the one and only JSONPath truth in the end. The written standard, or the conjoined implementation?

I think it has to be the written standard in the end as we can't afford to maintain code indefinitely. This is the view taken by the IETF in RFC 7942 which advises stripping out the implementations section before promoting an Internet Draft to a RFC.

from json-path-comparison.

cburgmer avatar cburgmer commented on June 1, 2024 1

I've changed Proposal A's handling. (Although I haven't spent time on refactoring, which might be necessary now that the logic is more complex.)
I've also added 4 test cases for begin and end for positive and negative steps each.
From my side I feel all is done.

from json-path-comparison.

cburgmer avatar cburgmer commented on June 1, 2024

Love the fuzzer, thanks for flagging.

I think we can agree that Proposal A's implementation in this part does not cover this input. At the time of writing it was more important for me to find a concise way of expressing the general intent, not so much trying to capture all cross functional requirements (like speed or low memory consumption).

The reason for this is that I don't believe that JSONPath can be implemented in exactly one way, but on the contrary, different implementations might focus on different aspects with different tradeoffs.

The case you flagged is somewhat borderline, so maybe we change this.

Related: What's going to be the arbiter on the one and only JSONPath truth in the end. The written standard, or the conjoined implementation?

from json-path-comparison.

cburgmer avatar cburgmer commented on June 1, 2024

Actually, now that I fixed the issue in the Proposal (had to add 4 test cases), I can see value in calling out this detail in a standard. Or at least to make sure this is captured in the reference test suite.

On that note, I'm not sure whether we agree on which document will become the test suite we want to push. Currently the Proposal A's own test suite is lagging a bit behind the one from the consensus. My personal goal was to drive forward the one from the consensus, which is why I'm adding more queries to the consensus for every issue you raise.
What do you think?

In that sense, I'd like to keep this issue open until I added the 4 necessary queries to the consensus itself.

from json-path-comparison.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.