Buggy ttml support about ccextractor HOT 5 CLOSED

Which version are you using I am getting correct output.

I am using git version from here.

from ccextractor.

Same here, I'm on latest commit (b95e06c).

I've started looking a bit at the code and it looks like it should only affect dvb_teletext subtitles.
It looks like it's around line 632 in file src/lib_ccx/telxcc.c: the switch only has a a CCX_OF_TRANSCRIPT and a default to srt.

I'm getting a more correct output by adding another case for smptett like this:

case CCX_OF_SMPTETT:
    timestamp_to_smptetttime(page->show_timestamp, timecode_show);
    timestamp_to_smptetttime(page->hide_timestamp, timecode_hide);
    if (ctx->wbout1.fh!=-1)
        fdprintf(ctx->wbout1.fh, "      <p region=\"speaker\" begin=\"%s\" end=\"%s\">%s</p>\n", timecode_show, timecode_hide, page_buffer_cur);

But this quick & dirty fix duplicate existing code to generate smptett and doesn't handle line ending correctly (the -lf param is completly ignored).

from ccextractor.

can you share your video file, I will look at it.

It seems teletext code is untouched from decades.
Actually correct solution would be not to write anything in the output file, We should pass decoder subtitle and things should be written there. If you look for dvb_subtitle and 608 things are like that.
and that decode sub context must be passed to encoder.

Now at time of initialization encoder writes the header and footer correctly, but it never gets the decode packet so that it can handle it.

and last question are you willing to contribute this in ccextractor.

from ccextractor.

I'd like to, but unfortunately I don't have the time right now to do it correctly.

from ccextractor.

Forgot to close this ticket when PR #123 was merged.

from ccextractor.