Giter VIP home page Giter VIP logo

Comments (4)

ccgus avatar ccgus commented on August 26, 2024

Do you have an example where you can show that it's broken?

from fmdb.

davedelong avatar davedelong commented on August 26, 2024

Actually, I think he has a point. Doesn't a va_list start with the first thing after the argument to va_start? In which case, the bindArgs parameter is never used, because it's not directly passed into executeUpdate:error:withArgumentsInArray:orVAList:, and it's not included in the va_list.

from fmdb.

ccgus avatar ccgus commented on August 26, 2024

Yea, looks like this method is completely broken. This is what I get for not having a test for it :)

from fmdb.

ccgus avatar ccgus commented on August 26, 2024

Ok, here's my dumb commit right here:
56a5e0f

Since it's obvious that nobody uses this method (as it just crashes when it's called with values) - maybe I should just dump it? @jaekwon- do have a use for this method?

from fmdb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.