add ability to change website title about unmark HOT 12 CLOSED

I agree, it'll be great if we can edit the saved bookmarks, including changing the title.

from unmark.

I started working on this... but I'm having an odd JavaScript issue http://cdevroe.com/blog/10366/odd-javascript-issue

from unmark.

OK. I'm nearing completion on this. Due to my woes with Vagrant I've decided to push the Milestone date up a bit. But, I think I should be able to tighten up 1.6.0 before the deadline I set for myself.

Any and all help appreciated!

from unmark.

(btw, I'll push a feature branch with this in it before pushing to Milestone branch incase someone wants to muck about with it and provide feedback)

from unmark.

Just a bit of an update here...

I've managed to get this mostly completed. I've made adjustments so that when editing Mark's notes you can also edit a Mark's title. I created a migration script for adding a custom Mark title column to the users_to_marks table and also updated the relevant models and views.

A few small things remain for me to button this up: 1) when leaving focus from the notes field to the title on the marks index view the "save" event triggers unwantingly. I still haven't tracked this down as it is unexpected. But, I'm sure it is there hiding somewhere. 2) I want the titles to also be editable from within the bookmarklet -- and not just in the main index view.

Once I have this I'll roll it into Milestone 1.6 branch. If anyone wants to take a crack at the focus issue... I've put the feature branch up here: https://github.com/plainmade/unmark/tree/52-editable-titles

from unmark.

Got the second thing done. Going to pick on that focus issue when I get back home from the office.

from unmark.

I believe this feature branch is ready for testing. Anyone willing to give it a go? /cc @simonschaufi @chansters

I'm going to muck about with it a bit today and then roll it into Milestone 1.6. And since Milestone 1.6 is nearly done I may roll it into the staging branch for full testing.

from unmark.

no need to cc us, i already get an email notification ;)

from unmark.

@simonschaufi Didn't know that. ;-) Is that always the case? Or, depends on how people have their notification preferences set up on GitHub?

from unmark.

i think github automatically sends you notifications if you join a conversation

from unmark.

This is now available for testing in the Milestone 1.6 branch.

from unmark.

We're testing this on our own Staging service and we've encountered a few interaction issues that we're cleaning up before launch. If you've found anything with this build that you'd like to report, please do so.

from unmark.