Giter VIP home page Giter VIP logo

Comments (7)

johnmay avatar johnmay commented on August 28, 2024 1

Polymers and CIP :-).

Unfortunately there are no rules (that I know of) for how CIP applies to polymers, do we weight the DUMMY atom infinitely heavy or light? For now it is safer to give no answer, in this case you get the same answer regardless but not always the case.

If I remember how the code works, if it can split ties before it "reaches" a DUMMY atom it gives you an answer it does, a slight modification shows this works as we expect:

*CC(=O)[C@@H](N)CCCCN* |Sg:n:1,2,3,4,5,6,7,8,9::ht|

The issue is the tie isn't split till you reach the C(=O)(*) at which point it sees dummy atom and gives up. In this case I think it is pos. to prove it's unambiguous - but extra logic is needed.

*C(=O)[C@@H](N)C(=O)*
[Au]C(=O)[C@@H](N)C(=O)[Pb]
[Pb]C(=O)[C@@H](N)C(=O)[Au]

Perhaps the most sane thing to do here is actually to cyclise the structure

C1(=O)[C@@H](N)CCCCN1

*C[C@@H](N)CCCCN*.C[C@@H](N)CCCCN.C1[C@@H](N)CCCCN1

S is correct here as we could also put in duplicates on each end and take the middle value:

from depict.

johnmay avatar johnmay commented on August 28, 2024 1

The centres/cip code is not polymer aware but yeah a reasonable approximation here would be to triplicate and then name it

from depict.

egonw avatar egonw commented on August 28, 2024

Right, yes, I guess that makes sense... I was thinking about the DUMMY being the repeat unit again, but that's not the case for all monomers, of course.

from depict.

egonw avatar egonw commented on August 28, 2024

I consider it a future wishlist

from depict.

johnmay avatar johnmay commented on August 28, 2024

Could you open issue tagged as feature request on centres repo please

from depict.

egonw avatar egonw commented on August 28, 2024

centres repo ?

from depict.

johnmay avatar johnmay commented on August 28, 2024

https://github.com/SiMolecule/centres/issues

from depict.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.