Comments (5)
@EysaN I'll take a look into what needs to be done for this one. Thanks for bringing it up!
from cdk-nag.
I think we can check if OriginAccessControlId
is configured in CloudFront origin.
https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-distribution-origin.html#cfn-cloudfront-distribution-origin-originaccesscontrolid
from cdk-nag.
I think there will need to be a few changes here
Streaming Distribution
CloudFront Streaming distributions don't seem to support OAC
s so the rule should be kept the same for Streaming Distributions
Distribution
@clueleaf I think you're correct that we need to check the OriginAccessControlId
property on Distributions. Additionally, if the OAC
is created in the stack, we should also check if the SigningBehavior isn't set to never
from cdk-nag.
Hi. Commenting from AWS ProServe Engagement Security:
We will wait until cdk-nag is updated, and then we'll update our guidance to ProServe builders. 😄
from cdk-nag.
Since currently we have to use addPropertyOverride
to configure OAC, and cdk-nag can not see overridden properties, I think supporting OAC in cdk-nag now will result in a lot of false positives.
Waiting for an L2 construct for OAC. (aws/aws-cdk#21771 aws/aws-cdk-rfcs#617)
from cdk-nag.
Related Issues (20)
- Need the compliance and non-compliance test cases for the typescript-cdk rulesshort issue description HOT 1
- bug: CodeBuildProjectSourceRepoUrl is out of date HOT 1
- feat: Test Utils as part of the library HOT 3
- Usage in pre-commit checks that only flag for brand new resources HOT 5
- bug: HIPAA.Security-RDSInBackupPlan not recognizing Serverless Postgres Cluster Instances HOT 1
- bug: SQS used as a DLQ on a lambda produces AwsSolutions-SQS3 HOT 1
- bug: ApplicationLoadBalancedFargateService not correctly detecting certificate with redirectHTTP HOT 1
- bug: CFN Resources go unchecked HOT 1
- feat: CIS Checks HOT 1
- feat: discourage use of DesiredCount for auto-scaled ECS services HOT 1
- AwsSolutions-SF1 conflicts with AWS recommendations HOT 2
- Do NagSuppressions have to be applied inside Stack constructor only? HOT 1
- feat: Serverless Nag Pack
- feat: Support for AWS Resource Tagging Standards HOT 2
- bug: AwsSolutions-L1 issue with Python runtime 3.12 HOT 1
- CloudFrontDistributionNoOutdatedSSL: Does not allow for s3 static hosting via cloudfront HOT 1
- Exported rules aren't typed correctly HOT 2
- feat: Simpler appliesTo syntax for referencing CDK nodes HOT 1
- bug: CDK Stages not linted by Nag rules HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cdk-nag.