Custom matchers fails to compile using Xcode 7.3 about cedar HOT 4 CLOSED

Hmm... even more interesting. I moved all of the code from the CustomMatchers.h file into the CedarComparators.h file, between the #ifdef CEDAR_CUSTOM_COMPARATORS guard, and I'm getting the same errors. I can safely remove the possibility of the CustomMatchers.h header file being the source of the issue.

from cedar.

Hey @PeqNP, I think I have an idea why you're experiencing this. With recent Cedar versions, Xcode tries to also build a Swift-compatible "module" version of Cedar, which can only include non-C++ components. This change means that all matchers (built-in and custom) need to be wrapped in an #ifdef __cplusplus / #endif block to ensure that they are only built in Objective-C++ mode. See here for an example. It looks like the documentation in the wiki still needs to be updated to reflect this. Let me know if this helps!

from cedar.

That solved the issue! Using the example in the Wiki, I ended up changing the code to look like this:

#import <CoreMedia/CoreMedia.h>

#if TARGET_OS_IPHONE
#import <Cedar-iOS/ComparatorsBase.h>
#import <Cedar-iOS/StringifiersBase.h>
#else
#import <Cedar/ComparatorsBase.h>
#import <Cedar/StringifiersBase.h>
#endif

#ifdef __cplusplus

namespace Cedar { namespace Matchers { namespace Comparators {
    template<typename U>
    bool compare_equal(CMTimeRange const actualValue, const U & expectedValue) {
        return CMTimeRangeEqual(actualValue, expectedValue);
    }
}}}

namespace Cedar { namespace Matchers { namespace Stringifiers {
    inline NSString * string_for(const CMTimeRange value) {
        return [NSString stringWithFormat:@"%lld/%d (duration %lld/%d)", value.start.value, value.start.timescale, value.duration.value, value.duration.timescale];
    }
}}}

#endif

Thank you for the response!

from cedar.

Note that this was an unintentional breaking change. 0b92d9e should fix this such that custom matchers won't need the guard to be manually inserted anymore.

from cedar.