Giter VIP home page Giter VIP logo

Comments (4)

CedricGuillemet avatar CedricGuillemet commented on July 16, 2024

Thanks! I'm taking a look :)

from imguizmo.

AndreiDespinoiu avatar AndreiDespinoiu commented on July 16, 2024

I can confirm that this is still present.

If your model is rotated, you only have to click the outer white circle (while in ImGuizmo::MODE::WORLD) for the rotation to reset to zero, not necessarily drag it.

Is there a way to detect if the outer white circle is interacted with? So I can tell it to temporarily switch back to LOCAL. This should probably be done automatically, in my opinion.

from imguizmo.

mamoniem avatar mamoniem commented on July 16, 2024

@AndreiDespinoiu the pull #94 should be a fix for that and for another scale related issue. But for some reason it didn't make it yet, and currently it has conflicts. I had similar fix locally, but this kinda broke the sync with the repo as sub-module.

from imguizmo.

crud89 avatar crud89 commented on July 16, 2024

I can confirm that this issue is now fixed in the latest version, which also makes PR #94 obsolete. The problem in version 1.83 originated from the fact, that the mModel matrix, which is set as follows, was used during scale instead of mModelSource.

if (mode == LOCAL)
{
    gContext.mModel = *(matrix_t*)matrix;
    gContext.mModel.OrthoNormalize();
}
else
{
    gContext.mModel.Translation(((matrix_t*)matrix)->v.position);
}

Note the WORLD branch only applies the translation. During HandleScale the delta matrix was thus also only multiplied with the translation, hence dropping the rotation completely. Translation and rotation both use the proper model matrix mModelSource. So the fix is to instead use this matrix for scale, too. This has already been changed in the current version.

tl;dr: this issue and PR #94 can be closed.

from imguizmo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.