Giter VIP home page Giter VIP logo

Comments (11)

adityakasturi8 avatar adityakasturi8 commented on July 20, 2024

Removed the multiple redaction in line 1663 and updated a new pull request.
Thank you.

from cs5293sp22.

nathanscain avatar nathanscain commented on July 20, 2024

There are more instances of this than those listed above:

@zwben lines 415 and 426
@minhtriet136 lines 784 and 785
@ramrao lines 813, 835, 870, 873, and 876
@bhargavvummadi line 1163
@adityakasturi8 line 1786
@CurSpace line 2440
@saiprakash1997 line 2633
@Gnan58 line 2918
@pinn0002 lines 2982, 2997, 3031, and 3057
@kaustubhpande73 line 3284
@VarshithaCVasireddy lines 3638 and 3674

from cs5293sp22.

cegme avatar cegme commented on July 20, 2024

Thanks. We'll try and keep track of updates.

from cs5293sp22.

cegme avatar cegme commented on July 20, 2024

@cegme. I believe it is a wrong tag. My lines are between line 1625 - line 1715

From line 1716 - 1804 it is @Aditya-Rohan-Singh .

In the latest, This is line 1786

adityakasturi8  validation  Tobel Basil Rathbone and Nigel Bruce return as Sherlock Holmes and Dr. Watson in this superior tale of Holmes battling the 3rd Reich and the mastermind genius of Professor Moriarty. The film opens up in Switzerland as Holmes is in disguise as an "old bookseller." He must bring Dr. █████ and the Bomb Site to England before the Germans can kidnap. Holmes succeeds and the Germans recuit the evil Professor. Moriarty manages to outwit Scotland yard and LeStrad "Dennis Hoey" by kidnapping █████. The only clue left by is a list of "dancing men." Who will break the hidden code of dancing men,

from cs5293sp22.

adityakasturi8 avatar adityakasturi8 commented on July 20, 2024

My Apologies. I did not upstream, I have fixed the mentioned, and created a new pull request. Thank you!

from cs5293sp22.

bhargavvummadi avatar bhargavvummadi commented on July 20, 2024

I have fixed that line and added new data, and created a new pull request. Thank you!

from cs5293sp22.

VarshithaCVasireddy avatar VarshithaCVasireddy commented on July 20, 2024

I fixed the issues in pull request #133. Please check them.

from cs5293sp22.

ramrao0102 avatar ramrao0102 commented on July 20, 2024

Hello,

Mine are not 2 separate redactions. They are the same redacted name that shows up twice in a sentence. You want them redacted, otherwise the label will end up in the sentence. Please check them.

from cs5293sp22.

cegme avatar cegme commented on July 20, 2024

@ramrao Each context should only have one redaction. It is fine if a redacted word is repeated in redacted in the context.

from cs5293sp22.

ramrao0102 avatar ramrao0102 commented on July 20, 2024

ok, so then I can change. How do I submit? Do I download the file, replace the 2 lines and resubmit a pull request?

from cs5293sp22.

cegme avatar cegme commented on July 20, 2024

ok, so then I can change. How do I submit? Do I download the file, replace the 2 lines and resubmit a pull request?

@ramrao0102 yes. unredact the extra redactions

from cs5293sp22.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.