Use rsmt2d lib with passed in NMT instead of repeating the logic in ll-core about celestia-core HOT 8 CLOSED

This is not actively being worked on. It should be a drop in replacement using the new Tree wrapper #238, but it would require some slight reorganizing to avoid an import cycle.

The wrapper itself relies on some constants defined in the types package, and is currently located in the ipld package. If we want to use the tree plugin in the types package we could:

1. move the constants outside of the types package along with moving the wrapper to it's own package
2. move the wrapper to the types package
3. move the wrapper to it's own package and make a reference to the constants in another package.

from celestia-core.

sounds good! I'll submit a PR later today tentatively using 3 and I think the consequences should be clearer after that.

from celestia-core.

This can be closed now too, I think?

from celestia-core.

We need to decide if we want to extend the rsmt2d API s.t. it can easily be used in ll-core, or, if we want to implement the parts that we need in ll-core instead.

related:

• celestiaorg/rsmt2d#12 (comment)
• #178 (comment)

from celestia-core.

😅 I actually wrote some code a while ago to add namespaces after computing the ExtendedDataSquare. That will be needed if we want to use the 'TreeCreator' portion of 'rsmt2d'. This is no longer needed, as the namespaces will be included in the shares.

from celestia-core.

Is this actively worked on as a followup to #237?

from celestia-core.

Cool! Sounds like a low-hanging fruit and that you already have a concrete plan how to tackle it 👍🏼 (I think 3. sounds like the best plan to me but I haven't thought it through really)

from celestia-core.

Confirmed: https://github.com/lazyledger/lazyledger-core/blob/6a4b0a7f21a856f17e72877bab374e9913798eef/types/block.go#L227-L244

from celestia-core.