Add string version for SimpleMap methods about smt HOT 4 CLOSED

Hmm, my bad, as SimpleMap is only used for testing.

from smt.

cc @odeke-em

from smt.

Note that only the SetString matter, the DeleteString and GetString are just the same as Delete and Get, but for completeness of APIs, better to introduce the string version for all methods.

If we don't care about backward-compatible, then we can just change the current methods signature, and also un-export SimpleMap, too, as it's highly coupled to internal usage only.

from smt.

The provided SimpleMap only exists so users can use the library with no external dependencies, e.g. for testing or prototyping purposes. It's absolutely not meant to be used in production; in production, a k-v store like RocksDB will be used that implements the MapStore interface, and for that it's important that the key used is a byte slice []byte since the key will be a hash or something.

TL;DR: no, the MapStore interface should not be changed to use a string as the key. And SimpleMap should not be removed if we want to allow users to start using the library with no external dependencies to at least prototype.

Also, your new benchmark is highly synthetic as it uses the same key over and over. In practice, that won't be the case. Instead, every operation will use a different key. And each key being different means allocating a new slice each time, something that your benchmark omits. If you allocate a new (different) string each iteration, you'll probably see the benchmarks being much closer together.

from smt.