Giter VIP home page Giter VIP logo

Comments (4)

lizadams avatar lizadams commented on August 28, 2024

issue: ****Fixed the wrong order of subtitle3 and subtitle2 when configure the subtitles;
Tried testing the verdi_config_v1 branch after Qun made changes to the verdi_config_v1 branch. Note, I only did a fetch, not a pull, so I at first I wasn't running with the updated code. After I did the pull, I was able to get all of the plots title to be in correct order correctly except for the Scatter Plot and the Vertical Cross Section Plot.

I was able to confirm that Subtitle 1 appears in the middle of Title 1 and Subtitle 2 for the FastTile Plot.
fasttile_order_of_titles_correct
Other plots were fixed including:
TimeSeries
Order of the titles is correct.
timeseries_order_of_tiles_correct
The order is correct, but there is another issue of Title1 disappearing when the user changes the layer
timeseries_layer2_title1_dissapears
For the Time Series and Time Series Bar plots I added another comment.
When I added Title 1 to the end of the existing title and then incremented the layer number, the Title 1 disappears.
I remember that Darren was able to fix the title disappearing issue for the fast tile plot.
Here is the link to that revision in source forge.
http://sourceforge.net/p/verdi/code/662/
I think it is easiest to see the changes he made using the side-by-side comparison view.
I think he needed to do a setSubTitle1 to get information from the data frame on what the SubTitle1 had been set to?
((TilePlotConfiguration) config).setSubtitle1(Tools.getDatasetNames(getDataFrame()));
I also remember why this may be more difficult for the Timeseries plot
Title 1 in the Timeseries plot is getting updated with a new Layer Number when the user increments the layer number.

TimeSeriesBar
Order for titles is correct
timeseriesbar_order_of_titles_correct_layer1
Title 1 disappears when user changes layer number
timeseriesbar_layer2_title1_dissapears
VerticalCrossSection
The title order is incorrect on this plot
verticalcrosssection_title_order_incorrect

Note: ScatterPlot configuration Option did not work at all - couldn't change the titles
scatter_cant_configure_titles

from verdi.

lizadams avatar lizadams commented on August 28, 2024

The code change that you made was to JChartTitlesLabels.
I ran it thru the debugger and put in a breakpoint on line 33 in JChartTitlesLabels.
It didn't stop at that line when I changed the titles for the FastTilePlot.
I then viewed the call Hierarchy and it shows that this code is only called by:
LinePlot, ScatterPlot, TimeSeriesBarPlot. The code change worked for those three plots, but did not work for the Vertical Cross Section Plot.
jcharttitleslables_call_hierarchy

from verdi.

lizadams avatar lizadams commented on August 28, 2024

It seems that the FastTilePlot doesn't use JChartTitlesLabels at all, and that the location of the SubTitle1 and Subtitle2 are set here:
fasttile_config_location_set_code

from verdi.

lizadams avatar lizadams commented on August 28, 2024

This task was completed under the verdi_config_v1 branch

from verdi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.