Prefix variable name with role name about ceph-ansible HOT 5 CLOSED

Unfortunately, I think we have reached a point where we can't implement this...

from ceph-ansible.

👍

from ceph-ansible.

Any chance this can be reconsidered?

If this is done improperly it can lead to disasters: an unaware user pulls from master and all of a sudden his variables do not override the defaults anymore.

But maybe there are safer ways, like an official fork for a 2.0 release cycle?

from ceph-ansible.

Well that's a though one, the next branch will drop support for 1.9.4 , so we can not have this one yet.
As you mentioned I think most of the users will be impacted by the change and it's hard to have something backward compatible.
We could potentially provide a transition script...
That's the only thing I can think of.

from ceph-ansible.

A transition script plus a check for "old" variables being still defined, which in case stops the playbook suggesting the user to run the script, could help.
It's still a huge impact.

OTOH, an accidental override caused by too generic names can also have big consequences (e.g., for users that have more than one role sharing e.g., some group_vars).
Without namespaced variable names, it's easy to unintentionally redefine variables with values that refer to other roles (I'm thinking about generic variable names such as "devices" or "pools").

from ceph-ansible.