Comments (8)
@cferdinandi Just wanting to give this a friendly nudge :) Since you said it is a fairly simple fix, is there anything I could put in as a quick fix? Thanks.
from tabby.
Ah, good catch! Can't commit to a completion date on this, but it's a fairly simple fix.
from tabby.
@cferdinandi Thank you for confirming this is an issue.
from tabby.
This is definitely a huge issue, sets id
to null
from tabby.
For anyone that cares, this particular problem is at line 403
I changed line 403 to the following:
if ( tab && tab.getAttribute( 'data-tab-id' )) {
I don't understand the full scope of the script, but that doesn't seem to have any negative side effects. Cheers
from tabby.
In its current form, the script removes the id to avoid page jumping, and then resets it when complete. If you comment out line 404, you break resetting the ID. Your check for the data-tab-id
is the right way to address this for the moment, until I get a proper fix in place.
Sorry for the delay. Been heads down on my JavaScript guides and courses.
from tabby.
So like... a year and a half too late here, but a fix for this is coming tomorrow
from tabby.
Fixed with v12: https://github.com/cferdinandi/tabby/releases/tag/v12.0.0
from tabby.
Related Issues (20)
- Nested tabs HOT 2
- Init Tabby only on mobile HOT 4
- Callback events? HOT 1
- Add previous tab to event HOT 3
- TypeError when no tabs exist on a page HOT 2
- Stop video when tab is inactive HOT 1
- Instantiate multiple instances with the same selector HOT 8
- Add ES6 module HOT 4
- 'tabby' event is not emitted when the tab ID is specified in the URL hash HOT 3
- CustomEvent polyfill is required for IE9+ support HOT 1
- CSS file not available via CDN HOT 2
- Implement Manual Activation HOT 3
- Add to documentation - instantiate multiple instances HOT 1
- Ability to call nested tabs with anchors?
- Make Tabby Work with Anchor Links from Outside HOT 2
- It is recommended that the Chinese character set is freely configured
- Where is download page? HOT 2
- bug occur when use sz (lrzsz utils) HOT 1
- Allow passing a node instead of a selector
- Scroll jump to anchor then back to top HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tabby.