tabby.toggleTab() prevents from clicking previous active tab about tabby HOT 8 CLOSED

@cferdinandi Just wanting to give this a friendly nudge :) Since you said it is a fairly simple fix, is there anything I could put in as a quick fix? Thanks.

from tabby.

Ah, good catch! Can't commit to a completion date on this, but it's a fairly simple fix.

from tabby.

@cferdinandi Thank you for confirming this is an issue.

from tabby.

This is definitely a huge issue, sets id to null

from tabby.

For anyone that cares, this particular problem is at line 403

I changed line 403 to the following:

if ( tab && tab.getAttribute( 'data-tab-id' )) {

I don't understand the full scope of the script, but that doesn't seem to have any negative side effects. Cheers

from tabby.

In its current form, the script removes the id to avoid page jumping, and then resets it when complete. If you comment out line 404, you break resetting the ID. Your check for the data-tab-id is the right way to address this for the moment, until I get a proper fix in place.

Sorry for the delay. Been heads down on my JavaScript guides and courses.

from tabby.

So like... a year and a half too late here, but a fix for this is coming tomorrow

from tabby.

Fixed with v12: https://github.com/cferdinandi/tabby/releases/tag/v12.0.0

from tabby.