Comments (4)
Actually, all of the 1005.2 terms are not identified as a key terms in the
source XML that we use. So, this is not a bug.
On Mon, Jun 3, 2013 at 1:11 PM, Adam Scott [email protected] wrote:
Key terms that are also definitions do not currently receive the key term
markup. For examples, see all of 1005.2 or 1005.3 b.In the case of 1005.3 b, it should be marked up as follows:
In the long-term, I think it would make the most sense not to exclude the
definition link as well (but that may need to be part of a larger
discussion):Electronic
fund transfer.—
Reply to this email directly or view it on GitHubhttps://github.com/eregs/regulations-site/issues/72
.
Shashank G. Khandelwal
http://skhandelwal.com
Travel Planning Made Easier
http://twyga.com
from regulations-site.
@cmc333333 Any thoughts?
from regulations-site.
1005.2 doesn't have any keyterms -- each paragraph begins with a sentence.
1005.3 b has this markup:
<dfn class="key-term" dfn-key-term="Electronic fund transfer"><a href="#1005-2-g" class="citation definition" data-definition="1005-2-g">Electronic fund transfer</a>.</dfn>
Is the problem that "Electronic fund transfer" should be slugized: "electronic-fund-transfer" or is something else missing?
from regulations-site.
The markup for 1005.3 b is correct. I must have been looking at an outdated version of the reg.
In the mockups, the defined terms within 1005.2 are given a different visual treatment, but the text doesn't fit the "key-term" structure. I'll close this and follow up in regards to design. Thanks!
from regulations-site.
Related Issues (20)
- Bad SSL certificate HOT 1
- Can someone add me as contributor to this repo? HOT 3
- Update README to include front-end building instructions HOT 2
- Inter-Reg Cross Reference Linking HOT 5
- DOM not updated when manually copy and pasting reg urls with anchor tags
- Run JS unit tests in Travis HOT 2
- Add frontendbuild.sh script HOT 2
- Add a loading indicator for Section by Section analysis
- Load inline "Official Interpretations" via Ajax HOT 2
- jQuery not being loaded on the About page
- Possible problem with loading indicator on defined terms? HOT 2
- Print stylesheet for tables HOT 1
- Move static src files to a top level src directory
- Back navigation from footnotes is off by a few lines HOT 1
- Appendix markers
- Incorrect interp url in navbar on ajax nav
- Leave NoneType alone!
- JS Error: Navigation links HOT 1
- JS Error: Section title on scroll HOT 1
- CSS error: slide-down interps
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from regulations-site.