Giter VIP home page Giter VIP logo

Comments (5)

cgm616 avatar cgm616 commented on June 25, 2024

Probably not a incompatibility? All the logs I've seen crash on -[VolumeBar resetTimer]

from volumebar9.

cgm616 avatar cgm616 commented on June 25, 2024

Logs with activator uninstalled:

This confirms that it's definitely something with only VolumeBar9.

from volumebar9.

cgm616 avatar cgm616 commented on June 25, 2024

When adding logging to the tweak, the problem seems to disappear. Still hard to know for sure. Below is what was added.

VolumeBar.xm

-(void)resetTimer {
  HBLogDebug(@"in resetTimer");
  if(hide != nil) {
    HBLogDebug(@"hide exists");
    [hide invalidate];
    HBLogDebug(@"hide invalidated");
    hide = nil;
    HBLogDebug(@"hide = nil now");
    hide = [NSTimer scheduledTimerWithTimeInterval:_delayTime target:self selector:@selector(_hideHUD) userInfo:nil repeats:NO];
    HBLogDebug(@"new hide created");
  }
}

Tweak.xm

%hook VolumeControl

-(void)increaseVolume {
  HBLogDebug(@"hooked increaseVolume");
  if(active && vbar != nil) {
    HBLogDebug(@"calling resetTimer");
    [vbar resetTimer];
  }

  %orig;
}

%end

from volumebar9.

cgm616 avatar cgm616 commented on June 25, 2024

One report has come in that the crash is actually from pressing the volume buttons and calling resetTimer while the banner is animating away.

from volumebar9.

cgm616 avatar cgm616 commented on June 25, 2024

I was able to reproduce it in this way! Sweet, should be a relatively easy fix to disable any functionality of resetTimer after hideHUD has been called.

from volumebar9.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.