Giter VIP home page Giter VIP logo

Comments (3)

STRML avatar STRML commented on July 19, 2024

Seems this could be fixed by checking both sides in the entry point:

  // Primitives/null/undefined can be checked for referential equality; returning early
  if (
    typeof leftHandOperand !== 'object' ||
    leftHandOperand === null ||
    leftHandOperand === undefined || // eslint-disable-line no-undefined
    typeof rightHandOperand !== 'object' ||
    rightHandOperand === null ||
    rightHandOperand === undefined // eslint-disable-line no-undefined
  ) {
    return leftHandOperand === rightHandOperand;
  }

Any reason not to?

from deep-eql.

keithamus avatar keithamus commented on July 19, 2024

Thanks for the issue @STRML, also thanks for the proposed solution. Seems completely reasonable to me, if you'd like to write a PR with your proposed solution and some tests, that'd be aaawwwesome! 😝


Edit: nvm, I see you have made one! Thanks, I'll review it πŸ˜„

from deep-eql.

lucasfcosta avatar lucasfcosta commented on July 19, 2024

Thanks for your work @STRML! Great job πŸ˜„

from deep-eql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.