Comments (3)
Seems this could be fixed by checking both sides in the entry point:
// Primitives/null/undefined can be checked for referential equality; returning early
if (
typeof leftHandOperand !== 'object' ||
leftHandOperand === null ||
leftHandOperand === undefined || // eslint-disable-line no-undefined
typeof rightHandOperand !== 'object' ||
rightHandOperand === null ||
rightHandOperand === undefined // eslint-disable-line no-undefined
) {
return leftHandOperand === rightHandOperand;
}
Any reason not to?
from deep-eql.
Thanks for the issue @STRML, also thanks for the proposed solution. Seems completely reasonable to me, if you'd like to write a PR with your proposed solution and some tests, that'd be aaawwwesome!
Edit: nvm, I see you have made one! Thanks, I'll review it
from deep-eql.
Thanks for your work @STRML! Great job
from deep-eql.
Related Issues (20)
- Comparing Properties with getters only HOT 3
- Dataview comparison ignores offsets HOT 2
- 'function' comparison
- objectEqual Sorts Keys Before Compare HOT 2
- Build failing due to change in error comparison algo HOT 2
- New version not automatically released HOT 4
- Assertion error does not state problematic parts for Maps HOT 1
- Comparison between uninitialized arrays fail HOT 3
- Get mismatch info? HOT 1
- Deep equality with a set depth
- Test project in Safari, Chrome, Firefox and Edge in the GitHub action
- URLSearchParams deep equal not working HOT 2
- Add TypeScript types
- Update karma package version to the newer one to support newer nodejs version HOT 1
- ChainAlert: new npm maintainer has published version 4.0.1 of package deep-eql
- Support for tc39/proposal-temporal HOT 1
- TypeError: Cannot convert a Symbol value to a string
- Donβt compare non-enumerable symbols HOT 4
- Feature request: Add possibility to exclude/omit keys when comparing objects HOT 2
- Loosely comparator with Set gives false result HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deep-eql.