Until recently, my team was using Node.js v18.13.0. Our CI system picked up Node.js v1

Is searchParams enumerable? I think a <code class="no

Hey <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url=

Cannot reliably compare Ada-based URLs (Node.js v18.17.0 & newer) about deep-eql HOT 2 OPEN

chaijs commented on August 18, 2024

Cannot reliably compare Ada-based URLs (Node.js v18.17.0 & newer)

from deep-eql.

Comments (2)

keithamus commented on August 18, 2024

Is searchParams enumerable? I think a URL will land here:

deep-eql/index.js

Line 416 in b8c9954

function keysEqual(leftHandOperand, rightHandOperand, keys, options) {

and each key will be checked by getting the property, so I don't know why it would fail.

Oh... unless you're saying the property that houses Symbol(query) is enumerable?

from deep-eql.

markandrus commented on August 18, 2024

Hey @keithamus,

Oh... unless you're saying the property that houses Symbol(query) is enumerable?

Yes! Symbol(query) is enumerable, and in Node.js < v18.17.0, Symbol(query) it was always present. Now, in Node.js v18.17.0 (or any version using Ada), Symbol(query) is lazily computed once searchParams is accessed. We can see that here:

Node.js v18.17.0

$ node
Welcome to Node.js v18.17.0.
Type ".help" for more information.
> var url = new URL('foo://bar')
undefined
> Object.getOwnPropertyNames(url)
[]
> Object.getOwnPropertySymbols(url)
[ Symbol(context) ] // ← Symbol(query) is missing
> void url.searchParams
undefined
> Object.getOwnPropertyNames(url)
[]
> Object.getOwnPropertySymbols(url)
[ Symbol(context), Symbol(query) ] // ← Symbol(query) is present and enumerable after accessing searchParams

Node.js v18.13.0

$ node                       
Welcome to Node.js v18.13.0.
Type ".help" for more information.
> var url = new URL('foo://bar')
undefined
> Object.getOwnPropertyNames(url)
[]
> Object.getOwnPropertySymbols(url)
[ Symbol(context), Symbol(query) ] // ← Symbol(query) is present and enumerable
> void url.searchParams
undefined
> Object.getOwnPropertyNames(url)
[]
> Object.getOwnPropertySymbols(url)
[ Symbol(context), Symbol(query) ] // ← Symbol(query) is still present and enumerable

from deep-eql.

Recommend Projects