Giter VIP home page Giter VIP logo

Comments (2)

chainlist avatar chainlist commented on July 27, 2024 1

Hi!

Sure thing, thank for the PR!

For you question:

  1. For now, I'm manually changing the version number, I need to automatize everything. But very taken with this end of quarter.
  2. package-lock.json should not be committed though as I personally prefer to use pnpm instead of npm.

from svelte-forms.

omer-g avatar omer-g commented on July 27, 2024

Hey @chainlist ,
I cloned the repo, fixed the issue and wrote a test for it. Would be happy to make a PR, but would appreciate if you could answer a few technical questions:

  1. I did npm install and it added package-lock.json. Should this file be committed in the PR, or should I add it to .gitignore? (or something else?)
  2. How to treat versioning? Should I just manually change version in package.json and CHANGELOG to 2.3.1?

from svelte-forms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.