Error: Heartbeat timer is already running about js-libp2p-gossipsub HOT 7 CLOSED

So after bit more digging in our code, I have actually discovered that we were actually calling start() twice, so that was the cause 😅

But you actually helped me debugging other problems I had with your last suggestion so, thanks a lot!

from js-libp2p-gossipsub.

Hello @AuHau
Can you let me know the versions you are using?
It seems that gossipsub.start is called multiple times

from js-libp2p-gossipsub.

Sure, here: https://github.com/rsksmart/rif-communications-pubsub/blob/master/package.json#L45

We construct our libp2p instance mostly like this: https://github.com/rsksmart/rif-communications-pubsub/tree/master/src/libp2p

And we use the pubsub like this: https://github.com/rsksmart/rif-communications-pubsub/blob/master/src/pubsub.ts#L41

from js-libp2p-gossipsub.

So, something is triggering the second start of heartbeat. Nothing bad should be happening because it is already running.

https://github.com/ChainSafe/js-libp2p-gossipsub/blob/v0.4.6/ts/heartbeat.ts#L30
https://github.com/ChainSafe/js-libp2p-gossipsub/blob/v0.4.6/ts/index.ts#L382

We are actually removing this error from the new gossipsub code and just return if already running. However, the start should not be called twice. When you do libp2p.start() it calls pubsub.start that calls hearbeat.start. I could only find in your code libp2p.start, which seems correct. It would be nice if you could do a console.trace() in the source of gossipsub before the throw, so that we can see where the second start is coming from

from js-libp2p-gossipsub.

That is great idea! Should have thought of that, will try. Thanks!

from js-libp2p-gossipsub.

Hmm the trace is not much helpful as it is pretty much the same as in the first message for both of calls. I have putted before the start() so yes there are two call but I think they should be from different libp2p instances.

But made me think. Is it alright to spawn multiple libp2p instances? We need those for tests and maybe there is some "singleton" pattern here that leads to this duplicated call?

from js-libp2p-gossipsub.

But made me think. Is it alright to spawn multiple libp2p instances?

Yes, but they should have different peerIds. It is normal to have multiple logs if you have multiple peer ids. You can also log the peer Id there, IIRC that version should have a gossipsub.peerId or gossipsub._peerId property

from js-libp2p-gossipsub.