Expose hooks for message validator before replaying about js-libp2p-gossipsub HOT 7 CLOSED

I'm thinking of doing something like this in our gossipsub impl in lodestar.
eg:

class LodestarGossipSub extends Gossipsub {
  // fancy features
}

Pubsub/Gossipsub provides a validate(message): boolean that we can/will need to overload that gets called in the right spot.

from js-libp2p-gossipsub.

Pubsub/Gossipsub provides a validate(message): boolean that we can/will need to overload that gets called in the right spot.

That was my first idea, but then we would have to decode message twice. First time in validate, second time when event is received.
Other problem is that in validate we don't know the topic and thus we don't know how to decode message.

from js-libp2p-gossipsub.

The decoding twice thing is definitely not ideal. We might want to tweak things there.

RE not knowing the topic, the message object that validate receives has a list of topics attached, so we can dispatch to a topic-specific validating function if we have it around.
eg something like:

interface Message {
  from?: Buffer;
  data?: Buffer;
  seqno?: Buffer;
  topicIDs: string[];
  signature?: Buffer;
  key?: Buffer;
}
class MyGossip {
  topicValidators: Map<string, (message: Message): boolean>;
  validate(message: Message): boolean {
    return message.topicIDs
      .map(topic => this.topicValidators.get(topic))
      .every(validator=> !validator || validator(message));
  } 
}

from js-libp2p-gossipsub.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

from js-libp2p-gossipsub.

Unstale

from js-libp2p-gossipsub.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

from js-libp2p-gossipsub.

This issue was done.

from js-libp2p-gossipsub.