Releasing via Aegir about js-libp2p-gossipsub HOT 10 CLOSED

@mpetrunic I am ok with that. But, I would recommend creating an issue in aegir to get this discussed

from js-libp2p-gossipsub.

Maybe we can fork aegir and rename to aegir-ts where we would adjust tools to expect ts. Later on upstream to aegir - - ts flag or something. We could you custom aegir in noise repo (we have custom scripts and lint there)

from js-libp2p-gossipsub.

Yeah, checking in src/ probably causes more problems than we want.

👍 on releasing w a custom aegir for now.

I think ideally, aegir could have extensions for typescript projects. Add a 'compile' step that could be flagged. I can envision a --ts flag that augments linting, releasing, building, etc to support our (or a similar) flow.
@mpetrunic I think we're thinking along the same lines

from js-libp2p-gossipsub.

1. we can do --lint=false and add a prerelease with lint?

2. should we also add tscto prerelease?

what do you think?

from js-libp2p-gossipsub.

1. sounds good

2. aegir treats this as a 'dirty repo' since the src files aren't checked in

from js-libp2p-gossipsub.

Humm, skipping the dirty repo for now would be the best approach, I think. Aegir should not support it, but it should be easy to add.
Checking the src seems strange and might create confusion for other contributors.

What do you think? Maybe you can open an issue in aegir to discuss it first? Meanwhile, I can release this with a custom aegir to avoid the dirty repo thing

from js-libp2p-gossipsub.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

from js-libp2p-gossipsub.

unstale

from js-libp2p-gossipsub.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

from js-libp2p-gossipsub.

This issue or pull request has been automatically been closed due to inactivity.

from js-libp2p-gossipsub.