Giter VIP home page Giter VIP logo

Comments (5)

segunadebayo avatar segunadebayo commented on May 2, 2024 1

I've found the resolved the issue. Thanks for spotting it.

I'll release a patch soon.

from chakra-ui.

segunadebayo avatar segunadebayo commented on May 2, 2024

Hi @jmaicaaan,

Can you put this on Codesandbox so I can take a look? It's most likely a type def issue.

from chakra-ui.

jmaicaaan avatar jmaicaaan commented on May 2, 2024

I saw the fix regarding the 6xl. Adding a static type def is fine for the base type def. But I am wondering if it's possible to get values from the Theme with types?

For example, I added a semantic font size name like "header".

{
     ...otherFontSizes,
    "header": "28px"
}

<Box fontSize="header">Hello<Box />

What do you think?

from chakra-ui.

segunadebayo avatar segunadebayo commented on May 2, 2024

Yes, this should work as well @jmaicaaan .

In the type def, we made it flexible to support any custom value in the theme.

If it doesn't work, send me a codesandbox link so I can take a look.

from chakra-ui.

jmaicaaan avatar jmaicaaan commented on May 2, 2024

@segunadebayo - Here is the codesandbox https://codesandbox.io/embed/react-typescript-4w0sv

Not sure if my expectation is possible ATM. Let me know what you think again. Thanks!

from chakra-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.