Giter VIP home page Giter VIP logo

Comments (2)

segunadebayo avatar segunadebayo commented on May 22, 2024

Thanks for digging into the issue and suggesting a fix.

I don't recommend importing the svg file in the theme file. Kindly refactor it to separate the theme from the custom component code.

You can also keep the patch for now. In the v3 version, we'll consider it.

from chakra-ui.

jerelmiller avatar jerelmiller commented on May 22, 2024

Hey @segunadebayo appreciate the response!

We don't have svg imports directly in our theme file. Our structure is roughly equivalent to the following:

// ChakraThemeProvider.tsx
import {
  AlertStyles,
  CheckboxStyles,
  // ...etc
} from 'our-ui-library';

const theme = extendTheme({
  components: {
    Alert: AlertStyles,
    Checkbox: CheckboxStyles,
    // ...etc
  }
})

where our-ui-library is an (internal) npm package with an index file that looks like this:

// index.ts
export { Checkbox } from './src/Checkbox';
export { CheckboxStyles } from './src/Checkbox.style';

In this case Checkbox.tsx has an .svg import that is used with the file. Our CLI is set to generate types from the ChakraThemeProvider.tsx file, but my guess is that esbuild is following the imports from the entry file and choking because it ends up trying to build the Checkbox.tsx file with the .svg imports.

Unfortunately its a bit difficult to change our file structure due to our-ui-library being a separate npm package. If I'm understanding what you're saying, we'd need to rethink our file/bundling structure in this package to ensure esbuild won't end up trying to build files in our internal package that have non-JS imports correct?

from chakra-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.