Comments (2)
Thanks for digging into the issue and suggesting a fix.
I don't recommend importing the svg
file in the theme file. Kindly refactor it to separate the theme from the custom component code.
You can also keep the patch for now. In the v3 version, we'll consider it.
from chakra-ui.
Hey @segunadebayo appreciate the response!
We don't have svg
imports directly in our theme file. Our structure is roughly equivalent to the following:
// ChakraThemeProvider.tsx
import {
AlertStyles,
CheckboxStyles,
// ...etc
} from 'our-ui-library';
const theme = extendTheme({
components: {
Alert: AlertStyles,
Checkbox: CheckboxStyles,
// ...etc
}
})
where our-ui-library
is an (internal) npm package with an index file that looks like this:
// index.ts
export { Checkbox } from './src/Checkbox';
export { CheckboxStyles } from './src/Checkbox.style';
In this case Checkbox.tsx
has an .svg
import that is used with the file. Our CLI is set to generate types from the ChakraThemeProvider.tsx
file, but my guess is that esbuild is following the imports from the entry file and choking because it ends up trying to build the Checkbox.tsx
file with the .svg
imports.
Unfortunately its a bit difficult to change our file structure due to our-ui-library
being a separate npm package. If I'm understanding what you're saying, we'd need to rethink our file/bundling structure in this package to ensure esbuild
won't end up trying to build files in our internal package that have non-JS imports correct?
from chakra-ui.
Related Issues (20)
- "ReferenceError: useOutsideClick is not defined" in website HOT 1
- Accordions don't have an opening transition on NextJs HOT 2
- Stepper is not keyboard accessible
- could not import image from local storage
- Compatibility Issue with react-focus-lock in Next.js Projects HOT 5
- 'react-focus-lock' is deprecated HOT 3
- Unknown URL come from Chakra-UI error on Console.
- --bg-modal not working if white color has been modified by theme
- Cannot read properties of null (reading 'registered') - Next.js
- Unable to build project on windows [ERR_MODULE_NOT_FOUND] HOT 1
- Support flex shorthand props for Badge component HOT 2
- Framer Motion props not accept proper types, when used with Flex component by doing "as={motion.div}"
- PopoverArrow did not apply the _dark property
- Support for `mode` prop for Transitions components
- "Edit this page on GitHub" link in documentation links to wrong page
- Drawer closeOnOverlayClick doesn't work
- Numbers Disappear in NumberInput When Typing Taiwanese Bopomofo
- When Tooltip is used in H5, the floating frame will disappear when clicked continuously. HOT 1
- When Tooltip is used in H5, I hope to add an attribute so that the floating frame will not disappear when clicked continuously. HOT 2
- Search keyboard shortcut not working on v2 website
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chakra-ui.