Giter VIP home page Giter VIP logo

Comments (20)

shone83 avatar shone83 commented on May 20, 2024 1

Yes, I see. These days I will test more and place here if I notice something if that's ok.

from unifiedtransform.

changeweb avatar changeweb commented on May 20, 2024 1

@ShekhSaifuddin007 Try this solution. If this work let me know. Then I will add this in Readme.md section as instructions.

from unifiedtransform.

changeweb avatar changeweb commented on May 20, 2024

@shone83 Good catch. oauth keys are not included because it should be different for each application. This is why this path is included in .gitignore file.

I added Passport package to support API. If anyone don't want to include this package then just follow these steps

  • Remove it from composer.json and run composer update and composer dump-autoload.

  • And all classes that relies on passport must be edited as well. The most common classes are:

    • app\User.php model, remove the HasApiToken trait.
    • app\Proiders\AuthServiceProvider, remove Passport::routes(); in your boot method.
    • In config/auth.php, change your driver option for api from passport to api authentication
    • Remove the Passport Migrations in database migrations table and run command artisan migrate:refresh

from unifiedtransform.

changeweb avatar changeweb commented on May 20, 2024

And giving which role to edit admin's data would be good? What do you think? And why?
I know only 2 languages properly. So I can't do proper translation in other popular languages.

Your help will be appreciated. You can add admin edit and translation features and make Pull Request here.

from unifiedtransform.

changeweb avatar changeweb commented on May 20, 2024

I've added Passport related instructions in readme.md with a pull request.

from unifiedtransform.

shone83 avatar shone83 commented on May 20, 2024

I think that master who create admin can also editing them and delete. Someone must be able to control them. Now you have situation that when admin is created no one can edit anything and what if master mad mistake in the project. Also, admin should have option to edit it's own profile, or just some parts.

I know that deleting is a problem because that removes id, but it must be some kind of set admin to non active. That is must have.

I planing to translate whole thing to Serbian when all errors are removed. I hope that would be helpfull to motivate others to translate to other languages.

from unifiedtransform.

changeweb avatar changeweb commented on May 20, 2024

@shone83 To make any user inactive we need to just set active field in users table to 0. It would be great if you can build edit features for master and admin!

I've started writing test cases. You can write tests too!

from unifiedtransform.

norbybaru avatar norbybaru commented on May 20, 2024

I agree with @shone83 I believe master should be able to manage school admin and school admin should able to update their details without being able to change their role or School

from unifiedtransform.

changeweb avatar changeweb commented on May 20, 2024

@shone83 @norbybaru Now you can activate, deactivate and edit Admin from Master account from view admin page

from unifiedtransform.

shone83 avatar shone83 commented on May 20, 2024

This topic can be used until all errors are corrected.

The further I noticed is that the count in the dashboard of professors and students does not work.

Also in Admin - Profile there is empty filed for nationality and religion. That fields not exist in form when master creating the admin. I do not think it's necessary.

from unifiedtransform.

changeweb avatar changeweb commented on May 20, 2024

@shone83 counts in Dashboard are Cached for 24hrs. It should be updated after 24hrs or if you delete cache files.

See in HomeController.php. I use cache here because these data are not frequently changed. But if you want you can comment the cache part. I will add instruction in readme.md

from unifiedtransform.

shone83 avatar shone83 commented on May 20, 2024

When I run composer install this error appear:

It is unsafe to run Dusk in production.
Script @php artisan package:discover handling the post-autoload-dump event returned with error code 1

Also, some columns in users migration is not nullable. It says:

 Integrity constraint violation: 1048 Column 'school_id' cannot be null

you must add this ->unsigned()->nullable() to accept null values. That is also for code and section_id columns.

from unifiedtransform.

changeweb avatar changeweb commented on May 20, 2024

@shone83 in Laravel's document also mentioned that running Dusk is not safe for production environment. To fix this run composer install --no-dev.

Can you make a pull request on user migration error?

from unifiedtransform.

shone83 avatar shone83 commented on May 20, 2024

As soon as to realize how to do that. I never done it before.

from unifiedtransform.

changeweb avatar changeweb commented on May 20, 2024

@shone83 there is a first time for everything 😃 .Try it!

from unifiedtransform.

ShekhSaifuddin007 avatar ShekhSaifuddin007 commented on May 20, 2024

When I run composer install --no-dev it also shows this error.
Script @php artisan package:discover handling the post-autoload-dump event returned with error code 1

from unifiedtransform.

ShekhSaifuddin007 avatar ShekhSaifuddin007 commented on May 20, 2024

I got another error that Class 'Rap2hpoutre\LaravelLogViewer\LaravelLogViewerServiceProvider' not found @changeweb how can i fix this.

from unifiedtransform.

changeweb avatar changeweb commented on May 20, 2024

@ShekhSaifuddin007 Check this link

The class keyword was added in PHP 5.5, so it will not work with your version. You should replace this (in your config/app.php in providers section):
Rap2hpoutre\LaravelLogViewer\LaravelLogViewerServiceProvider::class,
by this:
'\Rap2hpoutre\LaravelLogViewer\LaravelLogViewerServiceProvider',
And it will work. Source:
http://php.net/manual/en/language.oop5.basic.php#language.oop5.basic.class.class

from unifiedtransform.

ShekhSaifuddin007 avatar ShekhSaifuddin007 commented on May 20, 2024

@changeweb
I got the solution for this error Class 'Rap2hpoutre\LaravelLogViewer\LaravelLogViewerServiceProvider' not found by run this command composer require rap2hpoutre/laravel-log-viewer i got this from https://github.com/rap2hpoutre/laravel-log-viewer

from unifiedtransform.

ShekhSaifuddin007 avatar ShekhSaifuddin007 commented on May 20, 2024

@changeweb Btw I sent you an email if you like to check it out.

from unifiedtransform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.