Features to implement in core about chaos-core HOT 20 OPEN

Lets try the new TJ things.

click on an option to vote

To add an option :

[![](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/01BM9R8F6XQC1PN67RE2QV54EZ/**OPTION**)](https://m131jyck4m.execute-api.us-west-2.amazonaws.com/prod/poll/01BM9R8F6XQC1PN67RE2QV54EZ/**OPTION**/vote)

from chaos-core.

We could use Husky to ensure the use of prettier before commit.

from chaos-core.

@andrewda Have you tried jest? It's like mocha+chai but better (multithreading tests for instance).

Edit: it also has an option builtin for code coverage.

from chaos-core.

Yeah that's the idea, that prettier and eslint can be used together to enforce during coding and format after coding.

What I usually do is have prettier run on filesave and have eslint police me during the coding.

from chaos-core.

As for tests, I love mocha and chai. Also istanbul/NYC for code coverage.

from chaos-core.

@PlasmaPower haven't used it but works for me!

from chaos-core.

I was about to suggest jest, mainly as it's one package and I think we should be trying to minimise our external dependencies. Definitely not because I haven't used mocha/chai much, but using new tools is part of the challenge of different devs contributing to ChaosBot anyway imo

from chaos-core.

And jest is all included :

$ jest --coverage

from chaos-core.

Agreed, jest is definitely the way to go.

As far as contributing to this, should we contribute to the v2-pre-democracy branch or should we create our own branches and open PRs to that one?

from chaos-core.

Do we want to use some style guide like standard.js, Airbnb, etc.? Better to decide early.

from chaos-core.

@Redmega If you think the change might be controversial, open a PR, but if it's something simple or something that has already been agreed in an issue then I think it should be fine to commit directly to the branch.

from chaos-core.

Do we want to use some style guide like standard.js, Airbnb, etc.? Better to decide early.

I personnaly use XO

from chaos-core.

@andrewda I prefer Airbnb personally, but I'm open to a vote if someone compiles a list of presets to vote on

from chaos-core.

I'd say neither. Use prettier and be done with it. Just add some configuration to allow dangling underscores. I love me some dangling underscores.

Edit: Just checked out xo, looks cool. I wouldn't be averse to using that either.

from chaos-core.

@Swizz that's actually awesome! Airbnb and prettier sound like the best options to me. Voting for prettier just because it requires less setup.

from chaos-core.

As soon as I saw "new TJ thing" I knew it would be awesome 😄

from chaos-core.

I'm not a fan of relying on code formatters personally - I'd much rather use ESLint to ensure that the code is kept consistent (prettier-eslint, though, looks quite appealing).

from chaos-core.

@Redmega @Swizz I think we could use prettier-eslint-cli with a git hook if we're going to use eslint alongside prettier to ensure that the eslint rules don't simply get overridden by prettier straight away. Husky could also be used to ensure that the tests pass before a commit (although this might be frustrating for some people).

from chaos-core.

Add all the @Chaosthebot members into the loop

from chaos-core.

We've got another important choice to make:

We might want to also open a code formatting issue if this one's getting too big.

from chaos-core.