incorrect ponyfill for replaceAll() about ramda-adjunct HOT 5 CLOSED

@char0n this sounds reasonable, I think we should go this way

from ramda-adjunct.

Hi!

Thank you for the detailed issue description.

I'm working on it.

from ramda-adjunct.

Hi Guys,

I'm inclined to use R.replace as base for implementation for replaceAll ponyfill. The logic for special cases is complicated and it just seems unnecessary to re-implement it.

I'm suggesting following algorithm:

var find = 'abc';
var replace = 'a';
var re = new RegExp(RA.isRegExp(find) ? find : RA.escapeRegExp(find) , 'g');

R.replace(re, replace, 'abc.abc.abc');

If the search pattern is string we escape it and create a global regex pattern from it. If it's already regex we just convert it to global regex.

@js636f what do say ? With this solution we avoid complexities of implementing the logic.

from ramda-adjunct.

Fix is on master.

from ramda-adjunct.

Thank you!

from ramda-adjunct.