Comments (19)
yangchenyun
commented on June 1, 2024
5
For people have issue with this, github-review requires a separate entry in ~/.authinfo, even if it is the same token.
machine api.github.com login yangchenyun^github-review password ***
from github-review.
jperras
commented on June 1, 2024
3
For clarification, I do have a separate token for github-review with the scopes listed in the README.md, and this is my (redacted) authinfo:
machine api.github.com login jperras^forge password [REDACTED]
machine api.github.com login jperras^github-review password [REDACTED]
And for what it's worth, forge works as expected.
from github-review.
codygman
commented on June 1, 2024
I also tried adding more scopes from #65. I am using emacs 28.0.50 though, so maybe that causes an issue?
from github-review.
charignon
commented on June 1, 2024
That may cause the issue indeed, can you try with all the scopes, just in case? I cannot repro on emacs 27.1
from github-review.
Bikashd4332
commented on June 1, 2024
+1 I tried runninggitHub-review-start on GNU Emacs 27.1 and it gave the same exact error.
from github-review.
jperras
commented on June 1, 2024
I am also running into this bug, with GNU Emacs 27.1.91.
from github-review.
charignon
commented on June 1, 2024
This is concerning and I am investigating it now.
I tried a couple of different machines on 27.1 and I am not able to reproduce with the latest code on master. If I provide a patch to print more information, would you feel comfortable applying it and testing again?
I will update my emacs and all dependent packages and try to repro again.
from github-review.
jperras
commented on June 1, 2024
@charignon Sure, I'm game. It may be a mitigating factor, but I am using Doom Emacs; happy to help debug/test.
from github-review.
charignon
commented on June 1, 2024
I also tried the latest doom emacs and cannot repro. Sadly the deferred callback mechanism makes it hard to test, I believe that the issue is happening after you hear back from GitHub, let's confirm that.
Step 1) Clone the GitHub-review repo
Step 2) Open the github-review.el file
Step 3) Replace the function github-review-start-internal with the new version:
(defun github-review-start-internal (pr-alist)
"Start review given PR URL given PR-ALIST."
(message "0")
(deferred:$
(deferred:parallel
(lambda () (github-review-get-diff-deferred pr-alist))
(lambda () (github-review-get-pr-info-deferred pr-alist)))
(deferred:nextc it
(lambda (x)
(message "1")
(let-alist (-second-item x)
(message "2")
(let* ((prdata (a-assoc pr-alist 'sha .data.repository.pullRequest.headRef.target.oid))
(_ (message "3"))
(formatted-diff (github-review-format-diff (-first-item x) .data.repository.pullRequest))
(_ (message "4")))
(github-review-save-diff prdata formatted-diff)))))
(deferred:error it
(lambda (err)
(message "Got an error from the GitHub API %S!" err)))))Step 4) Evaluate the buffer
Step 5) Run github-review-start and repro the issue
Step 6) Look at the messages buffer and let me know what number printed there
from github-review.
codygman
commented on June 1, 2024
Hey, thanks for looking into this. Here's my output:
Mark saved where search started [2 times]
0
1
2
3
Got an error from the GitHub API (wrong-type-argument stringp nil)!
from github-review.
codygman
commented on June 1, 2024
Hmm... at least for me debugging this with edebug led me to see:
Result: #1=#s(deferred :callback deferred:parallel-alist-to-array :errorback deferred:default-errorback :cancel #f(compiled-function (x) #<bytecode 0x21bbdebc4aecb1a>) :next nil :status ok :value ((error "Required Github token (\"codygman^github-review\" fo...") (error "Required Github token (\"codygman^github-review\" fo...")))
I checked my .authinfo and sure enough it wasn't there... only the forge version. Maybe others are assuming like I must have that the forge version will work? I'm still testing this out to make sure it's working though.
from github-review.
jperras
commented on June 1, 2024
My output:
0
1
2
3
Got an error from the GitHub API (wrong-type-argument stringp nil)!
from github-review.
codygman
commented on June 1, 2024
My output:
0 1 2 3 Got an error from the GitHub API (wrong-type-argument stringp nil)!
@jperras If you want more debug output you like I found you can do this:
- Call
M-x edebug-set-breakpointon the line with(_ (message "3")) - Call
M-x github-review-startagain - It'll bring up the file at that breakpoint
- Since your in doom you should be able to hit
sto step through each line. - Then check your messages buffer for that output and redact anything necessary before posting
I'm not totally sure doom uses s for step, if not you can use M-x edebug-step-out. Since you have those details I'm guessing you'll get a shiny new error 😆
from github-review.
jperras
commented on June 1, 2024
So, I think I've (partially) solved my problem. Turns out the message that said I didn't have the token in my authinfo was right; my auth-sources path was set to only read the authinfo.gpg that I have setup, and completely ignored the unencrypted authinfo that I was using for testing. They just both so happened to share the same forge token.
Now I am getting the following:
Error talking to GitHub: ((error http 404 ((message . Not Found) (documentation_url . https://docs.github.com/rest/reference/pulls#get-a-pull-request))) ((Server . GitHub.com) (Date . Fri, 26 Mar 2021 18:06:40 GMT) (Content-Type . application/json; charset=utf-8) (Transfer-Encoding . chunked) (X-OAuth-Scopes . write:discussion) (X-GitHub-Media-Type . github.v3; param=diff) (X-RateLimit-Limit . 5000) (X-RateLimit-Remaining . 4994) (X-RateLimit-Reset . 1616782785) (X-RateLimit-Used . 6) (Access-Control-Expose-Headers . ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset) (Access-Control-Allow-Origin . *) (Strict-Transport-Security . max-age=31536000; includeSubdomains; preload) (X-Frame-Options . deny) (X-Content-Type-Options . nosniff) (X-XSS-Protection . 0) (Referrer-Policy . origin-when-cross-origin, strict-origin-when-cross-origin) (Content-Security-Policy . default-src 'none') (Vary . Accept-Encoding, Accept, X-Requested-With) (X-GitHub-Request-Id . D80B:3142:4DB3E:13CEFD:605E22B0)) (:error (error http 404 ((message . Not Found) (documentation_url . https://docs.github.com/rest/reference/pulls#get-a-pull-request))) :peer (:certificates ((:version 3 :serial-number 02:d5:f6:e5:55:e3:f9:1a:09:94:0d:c3:d9:b5:a4:83 :issuer C=US,O=DigiCert Inc,CN=DigiCert TLS Hybrid ECC SHA384 2020 CA1 :valid-from 2021-03-04 :valid-to 2022-03-09 :subject C=US,ST=California,L=San Francisco,O=GitHub\, Inc.,CN=*.github.com :public-key-algorithm EC/ECDSA :certificate-security-level High :signature-algorithm ECDSA-SHA384 :public-key-id sha1:ae:0e:40:ac:21:24:9b:c3:60:ab:c7:33:15:16:3f:d2:3d:68:94:87 :certificate-id sha1:e1:c0:97:bd:c1:36:cc:30:2c:89:e7:a6:bf:14:c0:21:14:72:bb:06 :pem -----BEGIN CERTIFICATE-----
MIIE6zCCBHGgAwIBAgIQAtX25VXj+RoJlA3D2bWkgzAKBggqhkjOPQQDAzBWMQsw
CQYDVQQGEwJVUzEVMBMGA1UEChMMRGlnaUNlcnQgSW5jMTAwLgYDVQQDEydEaWdp
Q2VydCBUTFMgSHlicmlkIEVDQyBTSEEzODQgMjAyMCBDQTEwHhcNMjEwMzA0MDAw
MDAwWhcNMjIwMzA5MjM1OTU5WjBoMQswCQYDVQQGEwJVUzETMBEGA1UECBMKQ2Fs
aWZvcm5pYTEWMBQGA1UEBxMNU2FuIEZyYW5jaXNjbzEVMBMGA1UEChMMR2l0SHVi
LCBJbmMuMRUwEwYDVQQDDAwqLmdpdGh1Yi5jb20wWTATBgcqhkjOPQIBBggqhkjO
PQMBBwNCAAQf8SePhtD7JeGm0YuTQ4HihyeENuvsNFdYPPIxIx6Lj9iOu2ECkgy4
52UR+mhIF24OvPizDveyCFOqmG/MI7kwo4IDDTCCAwkwHwYDVR0jBBgwFoAUCrwI
KReMpTlteg7OM8cus+37w3owHQYDVR0OBBYEFP5TUYtiCp+N3FISu3CqxMlJhdG1
MCMGA1UdEQQcMBqCDCouZ2l0aHViLmNvbYIKZ2l0aHViLmNvbTAOBgNVHQ8BAf8E
BAMCB4AwHQYDVR0lBBYwFAYIKwYBBQUHAwEGCCsGAQUFBwMCMIGXBgNVHR8EgY8w
gYwwRKBCoECGPmh0dHA6Ly9jcmwzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydFRMU0h5
YnJpZEVDQ1NIQTM4NDIwMjBDQTEuY3JsMESgQqBAhj5odHRwOi8vY3JsNC5kaWdp
Y2VydC5jb20vRGlnaUNlcnRUTFNIeWJyaWRFQ0NTSEEzODQyMDIwQ0ExLmNybDA+
BgNVHSAENzA1MDMGBmeBDAECAjApMCcGCCsGAQUFBwIBFhtodHRwOi8vd3d3LmRp
Z2ljZXJ0LmNvbS9DUFMwgYMGCCsGAQUFBwEBBHcwdTAkBggrBgEFBQcwAYYYaHR0
cDovL29jc3AuZGlnaWNlcnQuY29tME0GCCsGAQUFBzAChkFodHRwOi8vY2FjZXJ0
cy5kaWdpY2VydC5jb20vRGlnaUNlcnRUTFNIeWJyaWRFQ0NTSEEzODQyMDIwQ0Ex
LmNydDAMBgNVHRMBAf8EAjAAMIIBAwYKKwYBBAHWeQIEAgSB9ASB8QDvAHUAKXm+
8J45OSHwVnOfY6V35b5XfZxgCvj5TV0mXCVdx4QAAAF3/bWc4AAABAMARjBEAiBm
IdofaKj+XfeISM/2tjap1nQY1afFSBAcdw/YtgjmSQIgMqWoDyfO66suyk2VFcld
1C+WHUNGvXsCRPof5HG5QQgAdgAiRUUHWVUkVpY/oS/x922G4CMmY63AS39dxoNc
buIPAgAAAXf9tZ0CAAAEAwBHMEUCIQCJzwZRfAvv0izotFx2KE0sgV8O+NfuHUpa
1866RqKEtwIgc65P+xToSqPbp/J1gSFBJgySI/a1YoB+3p8xXTYaDsAwCgYIKoZI
zj0EAwMDaAAwZQIxAL8fIlMNWdeKHalpm9z+ksCuYT4tSN1ubXeNvDywr56me+yT
+fr42MnEcBdUtLOVOAIwPNC9fAJjyHHTL2vaRW1JRnrovLKDQVbZpZNIZnlY3WFu
kmxiBWDOpyfJrG9vQ25K
-----END CERTIFICATE-----
) (:version 3 :serial-number 0a:27:5f:e7:04:d6:ee:cb:23:d5:cd:5b:4b:1a:4e:04 :issuer C=US,O=DigiCert Inc,OU=www.digicert.com,CN=DigiCert Global Root CA :valid-from 2020-09-23 :valid-to 2030-09-22 :subject C=US,O=DigiCert Inc,CN=DigiCert TLS Hybrid ECC SHA384 2020 CA1 :public-key-algorithm EC/ECDSA :certificate-security-level Ultra :signature-algorithm RSA-SHA384 :public-key-id sha1:3f:a4:c2:7e:9c:9c:89:2c:6b:98:6c:1c:3e:1f:40:20:49:d4:48:5f :certificate-id sha1:51:e3:9a:8b:db:08:87:8c:52:d6:18:65:88:a0:fa:26:6a:69:cf:28 :pem -----BEGIN CERTIFICATE-----
MIIEQzCCAyugAwIBAgIQCidf5wTW7ssj1c1bSxpOBDANBgkqhkiG9w0BAQwFADBh
MQswCQYDVQQGEwJVUzEVMBMGA1UEChMMRGlnaUNlcnQgSW5jMRkwFwYDVQQLExB3
d3cuZGlnaWNlcnQuY29tMSAwHgYDVQQDExdEaWdpQ2VydCBHbG9iYWwgUm9vdCBD
QTAeFw0yMDA5MjMwMDAwMDBaFw0zMDA5MjIyMzU5NTlaMFYxCzAJBgNVBAYTAlVT
MRUwEwYDVQQKEwxEaWdpQ2VydCBJbmMxMDAuBgNVBAMTJ0RpZ2lDZXJ0IFRMUyBI
eWJyaWQgRUNDIFNIQTM4NCAyMDIwIENBMTB2MBAGByqGSM49AgEGBSuBBAAiA2IA
BMEbxppbmNmkKaDp1AS12+umsmxVwP/tmMZJLwYnUcu/cMEFesOxnYeJuq20ExfJ
qLSDyLiQ0cx0NTY8g3KwtdD3ImnI8YDEe0CPz2iHJlw5ifFNkU3aiYvkA8ND5b8v
c6OCAa4wggGqMB0GA1UdDgQWBBQKvAgpF4ylOW16Ds4zxy6z7fvDejAfBgNVHSME
GDAWgBQD3lA1VtFMu2bwo+IbG8OXsj3RVTAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0l
BBYwFAYIKwYBBQUHAwEGCCsGAQUFBwMCMBIGA1UdEwEB/wQIMAYBAf8CAQAwdgYI
KwYBBQUHAQEEajBoMCQGCCsGAQUFBzABhhhodHRwOi8vb2NzcC5kaWdpY2VydC5j
b20wQAYIKwYBBQUHMAKGNGh0dHA6Ly9jYWNlcnRzLmRpZ2ljZXJ0LmNvbS9EaWdp
Q2VydEdsb2JhbFJvb3RDQS5jcnQwewYDVR0fBHQwcjA3oDWgM4YxaHR0cDovL2Ny
bDMuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0R2xvYmFsUm9vdENBLmNybDA3oDWgM4Yx
aHR0cDovL2NybDQuZGlnaWNlcnQuY29tL0RpZ2lDZXJ0R2xvYmFsUm9vdENBLmNy
bDAwBgNVHSAEKTAnMAcGBWeBDAEBMAgGBmeBDAECATAIBgZngQwBAgIwCAYGZ4EM
AQIDMA0GCSqGSIb3DQEBDAUAA4IBAQDeOpcbhb17jApY4+PwCwYAeq9EYyp/3YFt
ERim+vc4YLGwOWK9uHsu8AjJkltz32WQt960V6zALxyZZ02LXvIBoa33llPN1d9R
JzcGRvJvPDGJLEoWKRGC5+23QhST4Nlg+j8cZMsywzEXJNmvPlVv/w+AbxsBCMqk
BGPI2lNM8hkmxPad31z6n58SXqJdH/bYF462YvgdgbYKOytobPAyTgr3mYI5sUje
CzqJx1+NLyc8nAK8Ib2HxnC+IrrWzfRLvVNve8KaN9EtBH7TuMwNW4SpDCmGr6fY
1h3tDjHhkTb9PA36zoaJzu0cIw265vZt6hCmYWJC+/j+fgZwcPwL
-----END CERTIFICATE-----
)) :certificate (:version 3 :serial-number 02:d5:f6:e5:55:e3:f9:1a:09:94:0d:c3:d9:b5:a4:83 :issuer C=US,O=DigiCert Inc,CN=DigiCert TLS Hybrid ECC SHA384 2020 CA1 :valid-from 2021-03-04 :valid-to 2022-03-09 :subject C=US,ST=California,L=San Francisco,O=GitHub\, Inc.,CN=*.github.com :public-key-algorithm EC/ECDSA :certificate-security-level High :signature-algorithm ECDSA-SHA384 :public-key-id sha1:ae:0e:40:ac:21:24:9b:c3:60:ab:c7:33:15:16:3f:d2:3d:68:94:87 :certificate-id sha1:e1:c0:97:bd:c1:36:cc:30:2c:89:e7:a6:bf:14:c0:21:14:72:bb:06 :pem -----BEGIN CERTIFICATE-----
MIIE6zCCBHGgAwIBAgIQAtX25VXj+RoJlA3D2bWkgzAKBggqhkjOPQQDAzBWMQsw
CQYDVQQGEwJVUzEVMBMGA1UEChMMRGlnaUNlcnQgSW5jMTAwLgYDVQQDEydEaWdp
Q2VydCBUTFMgSHlicmlkIEVDQyBTSEEzODQgMjAyMCBDQTEwHhcNMjEwMzA0MDAw
MDAwWhcNMjIwMzA5MjM1OTU5WjBoMQswCQYDVQQGEwJVUzETMBEGA1UECBMKQ2Fs
aWZvcm5pYTEWMBQGA1UEBxMNU2FuIEZyYW5jaXNjbzEVMBMGA1UEChMMR2l0SHVi
LCBJbmMuMRUwEwYDVQQDDAwqLmdpdGh1Yi5jb20wWTATBgcqhkjOPQIBBggqhkjO
PQMBBwNCAAQf8SePhtD7JeGm0YuTQ4HihyeENuvsNFdYPPIxIx6Lj9iOu2ECkgy4
52UR+mhIF24OvPizDveyCFOqmG/MI7kwo4IDDTCCAwkwHwYDVR0jBBgwFoAUCrwI
KReMpTlteg7OM8cus+37w3owHQYDVR0OBBYEFP5TUYtiCp+N3FISu3CqxMlJhdG1
MCMGA1UdEQQcMBqCDCouZ2l0aHViLmNvbYIKZ2l0aHViLmNvbTAOBgNVHQ8BAf8E
BAMCB4AwHQYDVR0lBBYwFAYIKwYBBQUHAwEGCCsGAQUFBwMCMIGXBgNVHR8EgY8w
gYwwRKBCoECGPmh0dHA6Ly9jcmwzLmRpZ2ljZXJ0LmNvbS9EaWdpQ2VydFRMU0h5
YnJpZEVDQ1NIQTM4NDIwMjBDQTEuY3JsMESgQqBAhj5odHRwOi8vY3JsNC5kaWdp
Y2VydC5jb20vRGlnaUNlcnRUTFNIeWJyaWRFQ0NTSEEzODQyMDIwQ0ExLmNybDA+
BgNVHSAENzA1MDMGBmeBDAECAjApMCcGCCsGAQUFBwIBFhtodHRwOi8vd3d3LmRp
Z2ljZXJ0LmNvbS9DUFMwgYMGCCsGAQUFBwEBBHcwdTAkBggrBgEFBQcwAYYYaHR0
cDovL29jc3AuZGlnaWNlcnQuY29tME0GCCsGAQUFBzAChkFodHRwOi8vY2FjZXJ0
cy5kaWdpY2VydC5jb20vRGlnaUNlcnRUTFNIeWJyaWRFQ0NTSEEzODQyMDIwQ0Ex
LmNydDAMBgNVHRMBAf8EAjAAMIIBAwYKKwYBBAHWeQIEAgSB9ASB8QDvAHUAKXm+
8J45OSHwVnOfY6V35b5XfZxgCvj5TV0mXCVdx4QAAAF3/bWc4AAABAMARjBEAiBm
IdofaKj+XfeISM/2tjap1nQY1afFSBAcdw/YtgjmSQIgMqWoDyfO66suyk2VFcld
1C+WHUNGvXsCRPof5HG5QQgAdgAiRUUHWVUkVpY/oS/x922G4CMmY63AS39dxoNc
buIPAgAAAXf9tZ0CAAAEAwBHMEUCIQCJzwZRfAvv0izotFx2KE0sgV8O+NfuHUpa
1866RqKEtwIgc65P+xToSqPbp/J1gSFBJgySI/a1YoB+3p8xXTYaDsAwCgYIKoZI
zj0EAwMDaAAwZQIxAL8fIlMNWdeKHalpm9z+ksCuYT4tSN1ubXeNvDywr56me+yT
+fr42MnEcBdUtLOVOAIwPNC9fAJjyHHTL2vaRW1JRnrovLKDQVbZpZNIZnlY3WFu
kmxiBWDOpyfJrG9vQ25K
-----END CERTIFICATE-----
) :key-exchange ECDHE-ECDSA :protocol TLS1.2 :cipher AES-128-GCM :mac AEAD :encrypt-then-mac nil :safe-renegotiation t)) #s(ghub--req #s(url https nil nil api.github.com nil /repos/fictivekin/neuxteuxdeuxteux/pulls/1093 nil nil t nil t t) nil nil GET (closure ((forge) (username . jperras) (auth . github-review) (host . api.github.com) (headers (Content-Type . application/json) (Accept . application/vnd.github.v3.diff)) cl-struct-ghub--req-tags url-http-response-status url-http-extra-headers url-http-end-of-headers url-callback-arguments t) nil (if (eq auth 'basic) (cons (cons Authorization (ghub--basic-auth host username)) headers) (cons (ghub--auth host auth username forge) headers))) ghub--handle-response t t nil #[128 \302\300\303\301�""\207 [#[642 \300��"\207 [deferred:callback-post] 6
(fn D V &rest _)] (#s(deferred identity deferred:default-errorback deferred:default-cancel #s(deferred (closure ((name . 0) (cd . #s(deferred (closure ((name . 1) #9 (pair 1 . #s(deferred #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2] deferred:default-errorback deferred:default-cancel #10 nil nil)) (--cl-var--) (values (1 (data (repository)))) (len . 2) (nd . #s(deferred deferred:default-callback deferred:default-errorback deferred:default-cancel #s(deferred deferred:parallel-alist-to-array deferred:default-errorback (closure ((v . #15) (rd . #15) (pd . #14) (lst #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2]) cl-struct-deferred-tags t) (x) (deferred:default-cancel x) (deferred:cancel pd)) #s(deferred #[257 \211A@\301\302\303\304\305\306��\236A\236A\236A\236A\236A\236A\304\305\306�\236A\236A\236A\307\310\300\311�#\312��@�""\266\202\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) oid target headRef pullRequest repository data github-review-save-diff a-assoc sha github-review-format-diff] 9
(fn X)] deferred:default-errorback deferred:default-cancel #s(deferred deferred:default-callback #[257 \300\301�"\207 [message Got an error from the GitHub API %S!] 4
(fn ERR)] deferred:default-cancel nil nil nil) nil nil) nil nil) nil nil)) (alst (0 . #s(deferred #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] deferred:default-errorback deferred:default-cancel #6 nil nil)) (1 . #s(deferred #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2] deferred:default-errorback deferred:default-cancel #10 nil nil))) cl-struct-deferred-tags t) (x) (setq values (cons (cons name x) values)) nil (if (= len (length values)) (progn nil (deferred:post-task nd 'ok (nreverse values)))) nil) deferred:default-errorback deferred:default-cancel #s(deferred deferred:default-callback (closure ((name . 1) #9 (pair 1 . #s(deferred #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2] deferred:default-errorback deferred:default-cancel #10 nil nil)) (--cl-var--) (values (1 (data (repository)))) (len . 2) (nd . #s(deferred deferred:default-callback deferred:default-errorback deferred:default-cancel #s(deferred deferred:parallel-alist-to-array deferred:default-errorback (closure ((v . #16) (rd . #16) (pd . #15) (lst #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2]) cl-struct-deferred-tags t) (x) (deferred:default-cancel x) (deferred:cancel pd)) #s(deferred #[257 \211A@\301\302\303\304\305\306��\236A\236A\236A\236A\236A\236A\304\305\306�\236A\236A\236A\307\310\300\311�#\312��@�""\266\202\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) oid target headRef pullRequest repository data github-review-save-diff a-assoc sha github-review-format-diff] 9
(fn X)] deferred:default-errorback deferred:default-cancel #s(deferred deferred:default-callback #[257 \300\301�"\207 [message Got an error from the GitHub API %S!] 4
(fn ERR)] deferred:default-cancel nil nil nil) nil nil) nil nil) nil nil)) (alst (0 . #s(deferred #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] deferred:default-errorback deferred:default-cancel #6 nil nil)) (1 . #s(deferred #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2] deferred:default-errorback deferred:default-cancel #10 nil nil))) cl-struct-deferred-tags t) (e) (setq values (cons (cons name e) values)) nil (if (= (length values) len) (progn nil (deferred:post-task nd 'ok (nreverse values)))) nil) deferred:default-cancel nil ok nil) nil nil)) (pair 1 . #s(deferred #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2] deferred:default-errorback deferred:default-cancel #s(deferred (closure ((name . 1) (cd . #11) #9 (--cl-var--) (values (1 (data (repository)))) (len . 2) (nd . #s(deferred deferred:default-callback deferred:default-errorback deferred:default-cancel #s(deferred deferred:parallel-alist-to-array deferred:default-errorback (closure ((v . #16) (rd . #16) (pd . #15) (lst #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2]) cl-struct-deferred-tags t) (x) (deferred:default-cancel x) (deferred:cancel pd)) #s(deferred #[257 \211A@\301\302\303\304\305\306��\236A\236A\236A\236A\236A\236A\304\305\306�\236A\236A\236A\307\310\300\311�#\312��@�""\266\202\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) oid target headRef pullRequest repository data github-review-save-diff a-assoc sha github-review-format-diff] 9
(fn X)] deferred:default-errorback deferred:default-cancel #s(deferred deferred:default-callback #[257 \300\301�"\207 [message Got an error from the GitHub API %S!] 4
(fn ERR)] deferred:default-cancel nil nil nil) nil nil) nil nil) nil nil)) (alst (0 . #s(deferred #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] deferred:default-errorback deferred:default-cancel #6 nil nil)) (1 . #10)) cl-struct-deferred-tags t) (x) (setq values (cons (cons name x) values)) nil (if (= len (length values)) (progn nil (deferred:post-task nd 'ok (nreverse values)))) nil) deferred:default-errorback deferred:default-cancel #s(deferred deferred:default-callback (closure ((name . 1) (cd . #11) #9 (--cl-var--) (values (1 (data (repository)))) (len . 2) (nd . #s(deferred deferred:default-callback deferred:default-errorback deferred:default-cancel #s(deferred deferred:parallel-alist-to-array deferred:default-errorback (closure ((v . #17) (rd . #17) (pd . #16) (lst #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2]) cl-struct-deferred-tags t) (x) (deferred:default-cancel x) (deferred:cancel pd)) #s(deferred #[257 \211A@\301\302\303\304\305\306��\236A\236A\236A\236A\236A\236A\304\305\306�\236A\236A\236A\307\310\300\311�#\312��@�""\266\202\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) oid target headRef pullRequest repository data github-review-save-diff a-assoc sha github-review-format-diff] 9
(fn X)] deferred:default-errorback deferred:default-cancel #s(deferred deferred:default-callback #[257 \300\301�"\207 [message Got an error from the GitHub API %S!] 4
(fn ERR)] deferred:default-cancel nil nil nil) nil nil) nil nil) nil nil)) (alst (0 . #s(deferred #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] deferred:default-errorback deferred:default-cancel #6 nil nil)) (1 . #10)) cl-struct-deferred-tags t) (e) (setq values (cons (cons name e) values)) nil (if (= (length values) len) (progn nil (deferred:post-task nd 'ok (nreverse values)))) nil) deferred:default-cancel nil ok nil) nil nil) nil nil)) (--cl-var--) (values (1 (data (repository)))) (len . 2) (nd . #s(deferred deferred:default-callback deferred:default-errorback deferred:default-cancel #s(deferred deferred:parallel-alist-to-array deferred:default-errorback (closure ((v . #11) (rd . #11) (pd . #10) (lst #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2]) cl-struct-deferred-tags t) (x) (deferred:default-cancel x) (deferred:cancel pd)) #s(deferred #[257 \211A@\301\302\303\304\305\306��\236A\236A\236A\236A\236A\236A\304\305\306�\236A\236A\236A\307\310\300\311�#\312��@�""\266\202\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) oid target headRef pullRequest repository data github-review-save-diff a-assoc sha github-review-format-diff] 9
(fn X)] deferred:default-errorback deferred:default-cancel #s(deferred deferred:default-callback #[257 \300\301�"\207 [message Got an error from the GitHub API %S!] 4
(fn ERR)] deferred:default-cancel nil nil nil) nil nil) nil nil) nil nil)) (alst (0 . #s(deferred #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] deferred:default-errorback deferred:default-cancel #6 nil nil)) (1 . #s(deferred #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2] deferred:default-errorback deferred:default-cancel #s(deferred (closure ((name . 1) (cd . #12) (pair 1 . #11) (--cl-var--) (values (1 (data (repository)))) (len . 2) (nd . #s(deferred deferred:default-callback deferred:default-errorback deferred:default-cancel #s(deferred deferred:parallel-alist-to-array deferred:default-errorback (closure ((v . #17) (rd . #17) (pd . #16) (lst #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2]) cl-struct-deferred-tags t) (x) (deferred:default-cancel x) (deferred:cancel pd)) #s(deferred #[257 \211A@\301\302\303\304\305\306��\236A\236A\236A\236A\236A\236A\304\305\306�\236A\236A\236A\307\310\300\311�#\312��@�""\266\202\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) oid target headRef pullRequest repository data github-review-save-diff a-assoc sha github-review-format-diff] 9
(fn X)] deferred:default-errorback deferred:default-cancel #s(deferred deferred:default-callback #[257 \300\301�"\207 [message Got an error from the GitHub API %S!] 4
(fn ERR)] deferred:default-cancel nil nil nil) nil nil) nil nil) nil nil)) #9 cl-struct-deferred-tags t) (x) (setq values (cons (cons name x) values)) nil (if (= len (length values)) (progn nil (deferred:post-task nd 'ok (nreverse values)))) nil) deferred:default-errorback deferred:default-cancel #s(deferred deferred:default-callback (closure ((name . 1) (cd . #12) (pair 1 . #11) (--cl-var--) (values (1 (data (repository)))) (len . 2) (nd . #s(deferred deferred:default-callback deferred:default-errorback deferred:default-cancel #s(deferred deferred:parallel-alist-to-array deferred:default-errorback (closure ((v . #18) (rd . #18) (pd . #17) (lst #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2]) cl-struct-deferred-tags t) (x) (deferred:default-cancel x) (deferred:cancel pd)) #s(deferred #[257 \211A@\301\302\303\304\305\306��\236A\236A\236A\236A\236A\236A\304\305\306�\236A\236A\236A\307\310\300\311�#\312��@�""\266\202\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) oid target headRef pullRequest repository data github-review-save-diff a-assoc sha github-review-format-diff] 9
(fn X)] deferred:default-errorback deferred:default-cancel #s(deferred deferred:default-callback #[257 \300\301�"\207 [message Got an error from the GitHub API %S!] 4
(fn ERR)] deferred:default-cancel nil nil nil) nil nil) nil nil) nil nil)) #9 cl-struct-deferred-tags t) (e) (setq values (cons (cons name e) values)) nil (if (= (length values) len) (progn nil (deferred:post-task nd 'ok (nreverse values)))) nil) deferred:default-cancel nil ok nil) nil nil) nil nil))) cl-struct-deferred-tags t) (x) (setq values (cons (cons name x) values)) nil (if (= len (length values)) (progn nil (deferred:post-task nd 'ok (nreverse values)))) nil) deferred:default-errorback deferred:default-cancel #s(deferred deferred:default-callback (closure ((name . 0) (cd . #s(deferred (closure ((name . 1) #10 (pair 1 . #s(deferred #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2] deferred:default-errorback deferred:default-cancel #11 nil nil)) (--cl-var--) (values (1 (data (repository)))) (len . 2) (nd . #s(deferred deferred:default-callback deferred:default-errorback deferred:default-cancel #s(deferred deferred:parallel-alist-to-array deferred:default-errorback (closure ((v . #16) (rd . #16) (pd . #15) (lst #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2]) cl-struct-deferred-tags t) (x) (deferred:default-cancel x) (deferred:cancel pd)) #s(deferred #[257 \211A@\301\302\303\304\305\306��\236A\236A\236A\236A\236A\236A\304\305\306�\236A\236A\236A\307\310\300\311�#\312��@�""\266\202\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) oid target headRef pullRequest repository data github-review-save-diff a-assoc sha github-review-format-diff] 9
(fn X)] deferred:default-errorback deferred:default-cancel #s(deferred deferred:default-callback #[257 \300\301�"\207 [message Got an error from the GitHub API %S!] 4
(fn ERR)] deferred:default-cancel nil nil nil) nil nil) nil nil) nil nil)) (alst (0 . #s(deferred #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] deferred:default-errorback deferred:default-cancel #6 nil nil)) (1 . #s(deferred #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2] deferred:default-errorback deferred:default-cancel #11 nil nil))) cl-struct-deferred-tags t) (x) (setq values (cons (cons name x) values)) nil (if (= len (length values)) (progn nil (deferred:post-task nd 'ok (nreverse values)))) nil) deferred:default-errorback deferred:default-cancel #s(deferred deferred:default-callback (closure ((name . 1) #10 (pair 1 . #s(deferred #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2] deferred:default-errorback deferred:default-cancel #11 nil nil)) (--cl-var--) (values (1 (data (repository)))) (len . 2) (nd . #s(deferred deferred:default-callback deferred:default-errorback deferred:default-cancel #s(deferred deferred:parallel-alist-to-array deferred:default-errorback (closure ((v . #17) (rd . #17) (pd . #16) (lst #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2]) cl-struct-deferred-tags t) (x) (deferred:default-cancel x) (deferred:cancel pd)) #s(deferred #[257 \211A@\301\302\303\304\305\306��\236A\236A\236A\236A\236A\236A\304\305\306�\236A\236A\236A\307\310\300\311�#\312��@�""\266\202\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) oid target headRef pullRequest repository data github-review-save-diff a-assoc sha github-review-format-diff] 9
(fn X)] deferred:default-errorback deferred:default-cancel #s(deferred deferred:default-callback #[257 \300\301�"\207 [message Got an error from the GitHub API %S!] 4
(fn ERR)] deferred:default-cancel nil nil nil) nil nil) nil nil) nil nil)) (alst (0 . #s(deferred #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] deferred:default-errorback deferred:default-cancel #6 nil nil)) (1 . #s(deferred #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2] deferred:default-errorback deferred:default-cancel #11 nil nil))) cl-struct-deferred-tags t) (e) (setq values (cons (cons name e) values)) nil (if (= (length values) len) (progn nil (deferred:post-task nd 'ok (nreverse values)))) nil) deferred:default-cancel nil ok nil) nil nil)) (pair 1 . #s(deferred #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2] deferred:default-errorback deferred:default-cancel #s(deferred (closure ((name . 1) (cd . #12) #10 (--cl-var--) (values (1 (data (repository)))) (len . 2) (nd . #s(deferred deferred:default-callback deferred:default-errorback deferred:default-cancel #s(deferred deferred:parallel-alist-to-array deferred:default-errorback (closure ((v . #17) (rd . #17) (pd . #16) (lst #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2]) cl-struct-deferred-tags t) (x) (deferred:default-cancel x) (deferred:cancel pd)) #s(deferred #[257 \211A@\301\302\303\304\305\306��\236A\236A\236A\236A\236A\236A\304\305\306�\236A\236A\236A\307\310\300\311�#\312��@�""\266\202\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) oid target headRef pullRequest repository data github-review-save-diff a-assoc sha github-review-format-diff] 9
(fn X)] deferred:default-errorback deferred:default-cancel #s(deferred deferred:default-callback #[257 \300\301�"\207 [message Got an error from the GitHub API %S!] 4
(fn ERR)] deferred:default-cancel nil nil nil) nil nil) nil nil) nil nil)) (alst (0 . #s(deferred #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] deferred:default-errorback deferred:default-cancel #6 nil nil)) (1 . #11)) cl-struct-deferred-tags t) (x) (setq values (cons (cons name x) values)) nil (if (= len (length values)) (progn nil (deferred:post-task nd 'ok (nreverse values)))) nil) deferred:default-errorback deferred:default-cancel #s(deferred deferred:default-callback (closure ((name . 1) (cd . #12) #10 (--cl-var--) (values (1 (data (repository)))) (len . 2) (nd . #s(deferred deferred:default-callback deferred:default-errorback deferred:default-cancel #s(deferred deferred:parallel-alist-to-array deferred:default-errorback (closure ((v . #18) (rd . #18) (pd . #17) (lst #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2]) cl-struct-deferred-tags t) (x) (deferred:default-cancel x) (deferred:cancel pd)) #s(deferred #[257 \211A@\301\302\303\304\305\306��\236A\236A\236A\236A\236A\236A\304\305\306�\236A\236A\236A\307\310\300\311�#\312��@�""\266\202\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) oid target headRef pullRequest repository data github-review-save-diff a-assoc sha github-review-format-diff] 9
(fn X)] deferred:default-errorback deferred:default-cancel #s(deferred deferred:default-callback #[257 \300\301�"\207 [message Got an error from the GitHub API %S!] 4
(fn ERR)] deferred:default-cancel nil nil nil) nil nil) nil nil) nil nil)) (alst (0 . #s(deferred #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] deferred:default-errorback deferred:default-cancel #6 nil nil)) (1 . #11)) cl-struct-deferred-tags t) (e) (setq values (cons (cons name e) values)) nil (if (= (length values) len) (progn nil (deferred:post-task nd 'ok (nreverse values)))) nil) deferred:default-cancel nil ok nil) nil nil) nil nil)) (--cl-var--) (values (1 (data (repository)))) (len . 2) (nd . #s(deferred deferred:default-callback deferred:default-errorback deferred:default-cancel #s(deferred deferred:parallel-alist-to-array deferred:default-errorback (closure ((v . #12) (rd . #12) (pd . #11) (lst #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2]) cl-struct-deferred-tags t) (x) (deferred:default-cancel x) (deferred:cancel pd)) #s(deferred #[257 \211A@\301\302\303\304\305\306��\236A\236A\236A\236A\236A\236A\304\305\306�\236A\236A\236A\307\310\300\311�#\312��@�""\266\202\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) oid target headRef pullRequest repository data github-review-save-diff a-assoc sha github-review-format-diff] 9
(fn X)] deferred:default-errorback deferred:default-cancel #s(deferred deferred:default-callback #[257 \300\301�"\207 [message Got an error from the GitHub API %S!] 4
(fn ERR)] deferred:default-cancel nil nil nil) nil nil) nil nil) nil nil)) (alst (0 . #s(deferred #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] deferred:default-errorback deferred:default-cancel #6 nil nil)) (1 . #s(deferred #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2] deferred:default-errorback deferred:default-cancel #s(deferred (closure ((name . 1) (cd . #13) (pair 1 . #12) (--cl-var--) (values (1 (data (repository)))) (len . 2) (nd . #s(deferred deferred:default-callback deferred:default-errorback deferred:default-cancel #s(deferred deferred:parallel-alist-to-array deferred:default-errorback (closure ((v . #18) (rd . #18) (pd . #17) (lst #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2]) cl-struct-deferred-tags t) (x) (deferred:default-cancel x) (deferred:cancel pd)) #s(deferred #[257 \211A@\301\302\303\304\305\306��\236A\236A\236A\236A\236A\236A\304\305\306�\236A\236A\236A\307\310\300\311�#\312��@�""\266\202\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) oid target headRef pullRequest repository data github-review-save-diff a-assoc sha github-review-format-diff] 9
(fn X)] deferred:default-errorback deferred:default-cancel #s(deferred deferred:default-callback #[257 \300\301�"\207 [message Got an error from the GitHub API %S!] 4
(fn ERR)] deferred:default-cancel nil nil nil) nil nil) nil nil) nil nil)) #10 cl-struct-deferred-tags t) (x) (setq values (cons (cons name x) values)) nil (if (= len (length values)) (progn nil (deferred:post-task nd 'ok (nreverse values)))) nil) deferred:default-errorback deferred:default-cancel #s(deferred deferred:default-callback (closure ((name . 1) (cd . #13) (pair 1 . #12) (--cl-var--) (values (1 (data (repository)))) (len . 2) (nd . #s(deferred deferred:default-callback deferred:default-errorback deferred:default-cancel #s(deferred deferred:parallel-alist-to-array deferred:default-errorback (closure ((v . #19) (rd . #19) (pd . #18) (lst #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-diff-deferred] 2] #[0 \301\300!\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) github-review-get-pr-info-deferred] 2]) cl-struct-deferred-tags t) (x) (deferred:default-cancel x) (deferred:cancel pd)) #s(deferred #[257 \211A@\301\302\303\304\305\306��\236A\236A\236A\236A\236A\236A\304\305\306�\236A\236A\236A\307\310\300\311�#\312��@�""\266\202\207 [((owner . fictivekin) (repo . neuxteuxdeuxteux) (apihost . api.github.com) (num . 1093)) oid target headRef pullRequest repository data github-review-save-diff a-assoc sha github-review-format-diff] 9
(fn X)] deferred:default-errorback deferred:default-cancel #s(deferred deferred:default-callback #[257 \300\301�"\207 [message Got an error from the GitHub API %S!] 4
(fn ERR)] deferred:default-cancel nil nil nil) nil nil) nil nil) nil nil)) #10 cl-struct-deferred-tags t) (e) (setq values (cons (cons name e) values)) nil (if (= (length values) len) (progn nil (deferred:post-task nd 'ok (nreverse values)))) nil) deferred:default-cancel nil ok nil) nil nil) nil nil))) cl-struct-deferred-tags t) (e) (setq values (cons (cons name e) values)) nil (if (= (length values) len) (progn nil (deferred:post-task nd 'ok (nreverse values)))) nil) deferred:default-cancel nil nil nil) nil nil) nil nil)) apply append] 6
(fn &rest ARGS2)] github-review-errback nil nil))This is when I attempted to review a pull request on a private repository that I have full permissions on, if that makes a difference.
from github-review.
freysteinn
commented on June 1, 2024
I am getting the same issue with GNU Emacs 27.2 when Forge is working fine.
Where you able to figure out what the problem was? Or should I also start going down the debugging hole? ;)
from github-review.
jperras
commented on June 1, 2024
@freysteinn I never did figure out what the problem was - I just ended up not using github-review in my process. Let me know if you find anything :)
from github-review.
jacobpmeyer
commented on June 1, 2024
For people have issue with this,
github-reviewrequires a separate entry in~/.authinfo, even if it is the same token.machine api.github.com login yangchenyun^github-review password ***
Didn't have a ~/.authinfo before and now that I do and have added it, the problem hasn't changed.
from github-review.
jacobpmeyer
commented on June 1, 2024
I am also on doom. I've tried the above, including the ^forge entry and even went so far to create a new gpg key, encrypt .authinfo, and decrypt from doom, as the doom core docs mention not wanting .authinfo to be plain text. It didn't effect anything. I still get the error mentioned at the very top. I've also tried editing my .gitconfig and deleting the [github] lines. This link was informative, but not helpful in this case: https://magit.vc/manual/ghub.html#Storing-a-Token
from github-review.
andrelkin
commented on June 1, 2024
I also had "wrong-type-argument string" error which turned out to be a bug in github-review-view-comments-in-code-lines-outdated == t branch of (github-review-place-review-comments). I've not fixed the branch yet, still to those who are interested an obvious workaround is to set the variable to nil.
from github-review.
Related Issues (20)
- Edit comments i gfm-mode HOT 2
- Code review is inconsistent if new codes gets pushed while reviewing
- Filter ^M characters in diffs
- Using graphql instead of api v3 for reducing number of network calls
- Document the token scope HOT 1
- Got an error from the GitHub API (wrong-type-argument listp error)! when i try to pull request using forge
- Add syntax highligh for review HOT 1
- docs need clarification (or code needs changing?) HOT 4
- Can only see topmost comment HOT 1
- Should start at the beginning of the buffer HOT 2
- Outline mode doesn't work with github-review-mode HOT 1
- improve diffs with delta
- Applying github-review-approve with no comments fails
- What's the Auth section of the README about? HOT 6
- Feature request - Magit Delta support HOT 1
- graphql seems to require _api.github.com/graphql_ in authinfo
- Readme info about doom-emacs appears to be outdated
- conflicts with `(setq diff-default-read-only t)` HOT 1
- Elisp errors are reported as coming from the GH API, and debug-on-error doesn't work HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-review.