Rule does not allow configuration of de/serializers about kafka-junit HOT 6 CLOSED

Hi,

I am certainly open to contributions. In the case of overriding the consumer config, I have been a bit reluctant to add support for it because I intended the pollMessages method to be just a convenience method for quickly testing whether your producer code worked or not. If the test required more effort than that, I expected the users to write the appropriate consumer code themselves because I felt that it was a rare enough use case that did not warrant adding extra parameters and method overrides to the code.

That being said, you're the second person to enquire about this. Can you tell me a little bit about your test scenario and what extra configuration properties are needed to make it work?

Thanks

from kafka-junit.

I ran into a case where I wanted to set the value.deserializer.encoding property and have it picked up by the StringDeserializer - I started out as you said, using the rule to create the basic configuration and then adding my new config to it, but then I realized that I would also have to create the consumer and the serializers (since they were not having configure called).

I agree that my solution is not the most elegant, but it got the job done. Maybe if there were another easy way to provide extra consumer/producer config, even through the constructor.

from kafka-junit.

That's a fair point. I'll think about it a little bit more and try to get something coded over the weekend. It'll probably be very similar to what you suggested anyway.

from kafka-junit.

So I did some refactoring and now you can provide configuration overrides when creating producers and consumers.

KafkaConsumer<String,String> consumer = kafkaRule.helper().createStringConsumer(overrideProps);
ListenableFuture<List<ConsumerRecord<String,String>>> records = kafkaRule.helper().consume(topic, consumer, numMessagesToConsume);

Version 3.0.0-SNAPSHOT is now available on Sonatype snapshots. This version contains breaking API changes so please refer to the README for more information. I'll cut a release in a couple of days after a few more tweaks.

from kafka-junit.

Great! I will check it out and give it a try soon. Thanks!

from kafka-junit.

I am assuming that this issue has been resolved. Feel free to re-open if that's not the case.

from kafka-junit.